[Extensions] Kill off ExtensionMsg_AddMessageToConsole

extensions/browser/extension_function.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "extensions/browser/extension_function.h"
 
 #include "base/logging.h"
 #include "base/memory/singleton.h"
 #include "base/synchronization/lock.h"
 #include "content/public/browser/notification_source.h"
@@ skipping 461 matching lines @@
 
 void UIThreadExtensionFunction::SetTransferredBlobUUIDs(
     const std::vector<std::string>& blob_uuids) {
   DCHECK(transferred_blob_uuids_.empty());  // Should only be called once.
   transferred_blob_uuids_ = blob_uuids;
 }
 
 void UIThreadExtensionFunction::WriteToConsole(
     content::ConsoleMessageLevel level,
     const std::string& message) {
-  render_frame_host_->Send(new ExtensionMsg_AddMessageToConsole(
-      render_frame_host_->GetRoutingID(), level, message));
+  WebContents::FromRenderFrameHost(render_frame_host_)

[not at google - send to devlin, 2015/06/19 23:14:58]

Can you just call render_frame_host_->AddMessageToConsole()?

[Devlin, 2015/06/19 23:53:51]

We should only call AddMessageToConsole on the main frame (two reasons: the main
frame is the only one that has dev tools installed [see render frame impl] and
this matches current behavior, in which console::AddMessage always used the main
frame).

[not at google - send to devlin, 2015/06/22 17:54:10]

Seems like a devtools bug, at least in their API, but ok.
Yes, I was hoping that logging to the RFH would be more correct and internally
devtools could figure out where to actually render those logs.

[Devlin, 2015/06/22 19:52:32]

Added comment.

+      ->GetMainFrame()
+      ->AddMessageToConsole(level, message);
 }
 
 IOThreadExtensionFunction::IOThreadExtensionFunction()
     : routing_id_(MSG_ROUTING_NONE) {
 }
 
 IOThreadExtensionFunction::~IOThreadExtensionFunction() {
 }
 
 IOThreadExtensionFunction*
@@ skipping 56 matching lines @@
 
 ExtensionFunction::ResponseAction SyncIOThreadExtensionFunction::Run() {
   return RespondNow(RunSync() ? ArgumentList(results_.Pass()) : Error(error_));
 }
 
 // static
 bool SyncIOThreadExtensionFunction::ValidationFailure(
     SyncIOThreadExtensionFunction* function) {
   return false;
 }