chrome/browser/extensions/api/declarative_content/declarative_content_apitest.cc - Issue 1200393002: Add more string_util functions to base namespace.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/declarative_content/declarative_content_apitest.cc

Issue 1200393002: Add more string_util functions to base namespace. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@string

Patch Set: Android Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/commands/command_service.cc ('k') | chrome/browser/extensions/api/media_galleries/media_galleries_apitest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/declarative_content/declarative_content_apitest.cc

diff --git a/chrome/browser/extensions/api/declarative_content/declarative_content_apitest.cc b/chrome/browser/extensions/api/declarative_content/declarative_content_apitest.cc

index adc530afda0c9e58c70cb26e72fab4eed3ae89a1..f993ee55b1e7eb393c3c9c2248be64042086564b 100644

--- a/chrome/browser/extensions/api/declarative_content/declarative_content_apitest.cc

+++ b/chrome/browser/extensions/api/declarative_content/declarative_content_apitest.cc

@@ -118,8 +118,9 @@ void DeclarativeContentApiTest::CheckIncognito(IncognitoMode mode,

bool is_enabled_in_incognito) {

std::string manifest = kDeclarativeContentManifest;

if (mode == SPLIT) {

- ReplaceSubstringsAfterOffset(&manifest, 0, "\"incognito\": \"spanning\"",

- "\"incognito\": \"split\"");

+ base::ReplaceSubstringsAfterOffset(

+ &manifest, 0, "\"incognito\": \"spanning\"",

+ "\"incognito\": \"split\"");

ASSERT_NE(kDeclarativeContentManifest, manifest);

}

ext_dir_.WriteManifest(manifest);

@@ -571,7 +572,7 @@ IN_PROC_BROWSER_TEST_F(DeclarativeContentApiTest,

IN_PROC_BROWSER_TEST_F(DeclarativeContentApiTest,

ShowPageActionWithoutPageAction) {

std::string manifest_without_page_action = kDeclarativeContentManifest;

- ReplaceSubstringsAfterOffset(

+ base::ReplaceSubstringsAfterOffset(

&manifest_without_page_action, 0, "\"page_action\": {},", "");

ASSERT_NE(kDeclarativeContentManifest, manifest_without_page_action);

ext_dir_.WriteManifest(manifest_without_page_action);