Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Unified Diff: tools/gn/command_args.cc

Issue 1200393002: Add more string_util functions to base namespace. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@string
Patch Set: Android Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/zlib/google/zip.cc ('k') | tools/gn/setup.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gn/command_args.cc
diff --git a/tools/gn/command_args.cc b/tools/gn/command_args.cc
index 518a1b69d3427c15e060e32820242d4369e49c46..a8b009764f26161bf8885ef18f701c8d99fc17a2 100644
--- a/tools/gn/command_args.cc
+++ b/tools/gn/command_args.cc
@@ -211,7 +211,7 @@ bool RunEditor(const base::FilePath& file_to_edit) {
// but quoting and escaping internal quotes should handle 99.999% of all
// cases.
std::string escaped_name = file_to_edit.value();
- ReplaceSubstringsAfterOffset(&escaped_name, 0, "\"", "\\\"");
+ base::ReplaceSubstringsAfterOffset(&escaped_name, 0, "\"", "\\\"");
cmd.append(escaped_name);
cmd.push_back('"');
@@ -250,7 +250,8 @@ int EditArgsFile(const std::string& build_dir) {
#if defined(OS_WIN)
// Use Windows lineendings for this file since it will often open in
// Notepad which can't handle Unix ones.
- ReplaceSubstringsAfterOffset(&argfile_default_contents, 0, "\n", "\r\n");
+ base::ReplaceSubstringsAfterOffset(
+ &argfile_default_contents, 0, "\n", "\r\n");
#endif
base::CreateDirectory(arg_file.DirName());
base::WriteFile(arg_file, argfile_default_contents.c_str(),
« no previous file with comments | « third_party/zlib/google/zip.cc ('k') | tools/gn/setup.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698