chrome/browser/ui/pdf/adobe_reader_info_win.cc - Issue 1200393002: Add more string_util functions to base namespace.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/pdf/adobe_reader_info_win.cc

Issue 1200393002: Add more string_util functions to base namespace. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@string

Patch Set: Android Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/pdf/adobe_reader_info_win.cc

diff --git a/chrome/browser/ui/pdf/adobe_reader_info_win.cc b/chrome/browser/ui/pdf/adobe_reader_info_win.cc

index ded85bc47029d74687789c1242d036ecc8c10f8c..4bdf62f0b8268013fb6849997a8817fe068eba36 100644

--- a/chrome/browser/ui/pdf/adobe_reader_info_win.cc

+++ b/chrome/browser/ui/pdf/adobe_reader_info_win.cc

@@ -180,7 +180,7 @@ bool IsAdobeReaderUpToDate() {

for (int i = 1; i <= 9; ++i) {

std::string from = base::StringPrintf(".0%d", i);

std::string to = base::StringPrintf(".%d", i);

- ReplaceSubstringsAfterOffset(&reader_version, 0, from, to);

+ base::ReplaceSubstringsAfterOffset(&reader_version, 0, from, to);

}

base::Version file_version(reader_version);

return file_version.IsValid() && !file_version.IsOlderThan(kSecureVersion);