chrome/browser/extensions/api/media_galleries/media_galleries_apitest.cc - Issue 1200393002: Add more string_util functions to base namespace.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/media_galleries/media_galleries_apitest.cc

Issue 1200393002: Add more string_util functions to base namespace. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@string

Patch Set: Android Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/declarative_content/declarative_content_apitest.cc ('k') | chrome/browser/extensions/api/settings_overrides/settings_overrides_api.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/media_galleries/media_galleries_apitest.cc

diff --git a/chrome/browser/extensions/api/media_galleries/media_galleries_apitest.cc b/chrome/browser/extensions/api/media_galleries/media_galleries_apitest.cc

index 67740e1e0c840f2cbb9879b5bf8d30e82b7d6fbf..6b7a947a865dab36d8d2b3e963987181f01bc828 100644

--- a/chrome/browser/extensions/api/media_galleries/media_galleries_apitest.cc

+++ b/chrome/browser/extensions/api/media_galleries/media_galleries_apitest.cc

@@ -365,10 +365,10 @@ class MediaGalleriesPlatformAppBrowserTest : public PlatformAppBrowserTest {

base::FilePath in_both_jpg = iphoto_data_root.AppendASCII("InBoth.jpg");

ASSERT_TRUE(base::CopyFile(test_jpg_path, first_only_jpg));

ASSERT_TRUE(base::CopyFile(test_jpg_path, in_both_jpg));

- ReplaceFirstSubstringAfterOffset(

- &xml_contents, 0, std::string("$path1"), first_only_jpg.value());

- ReplaceFirstSubstringAfterOffset(

- &xml_contents, 0, std::string("$path2"), in_both_jpg.value());

+ base::ReplaceFirstSubstringAfterOffset(

+ &xml_contents, 0, "$path1", first_only_jpg.value());

+ base::ReplaceFirstSubstringAfterOffset(

+ &xml_contents, 0, "$path2", in_both_jpg.value());

base::FilePath album_xml = iphoto_data_root.AppendASCII("AlbumData.xml");

ASSERT_NE(-1, base::WriteFile(album_xml,