Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Issue 11961022: Remove default constructors for QuicTime and QuicTime::Delta and used static Zero() methods instead… (Closed)

Created:
7 years, 11 months ago by Ryan Hamilton
Modified:
7 years, 11 months ago
CC:
chromium-reviews, pam+watch_chromium.org, cbentzel+watch_chromium.org, darin-cc_chromium.org
Visibility:
Public.

Description

Remove default constructors for QuicTime and QuicTime::Delta and used static Zero() methods instead to make it clear what value is being used. One annoying side-effect is this means that maps which have these objects as keys can't not be accessed with []. Thankfully, this is not a huge problem. (It only affects us in one place). But I can add the default constructors back to support this use case, if necessary. (I'd prefer not to since I think Zero() is more clear, but can go either way). Merge internal change: 40993340

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+79 lines, -60 lines) Patch
M net/quic/congestion_control/cubic.cc View 3 chunks +6 lines, -4 lines 0 comments Download
M net/quic/congestion_control/fix_rate_sender.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/congestion_control/fix_rate_test.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M net/quic/congestion_control/hybrid_slow_start.cc View 2 chunks +5 lines, -2 lines 0 comments Download
M net/quic/congestion_control/leaky_bucket.cc View 1 chunk +1 line, -0 lines 0 comments Download
M net/quic/congestion_control/paced_sender_test.cc View 1 chunk +2 lines, -1 line 0 comments Download
M net/quic/congestion_control/quic_receipt_metrics_collector_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/congestion_control/quic_send_scheduler_test.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M net/quic/congestion_control/tcp_cubic_sender.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M net/quic/congestion_control/tcp_receiver_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/quic_connection.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/quic_connection_helper_test.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M net/quic/quic_connection_test.cc View 8 chunks +10 lines, -7 lines 0 comments Download
M net/quic/quic_framer.cc View 3 chunks +7 lines, -4 lines 0 comments Download
M net/quic/quic_framer_test.cc View 2 chunks +10 lines, -7 lines 0 comments Download
M net/quic/quic_http_stream_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/quic_time.h View 2 chunks +7 lines, -6 lines 0 comments Download
M net/quic/quic_time.cc View 2 chunks +7 lines, -6 lines 2 comments Download
M net/quic/quic_time_test.cc View 3 chunks +5 lines, -4 lines 0 comments Download
M net/quic/test_tools/mock_clock.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Ryan Hamilton
7 years, 11 months ago (2013-01-16 19:59:01 UTC) #1
jar (doing other things)
lgtm https://codereview.chromium.org/11961022/diff/1/net/quic/quic_time.cc File net/quic/quic_time.cc (right): https://codereview.chromium.org/11961022/diff/1/net/quic/quic_time.cc#newcode14 net/quic/quic_time.cc:14: QuicTime::Delta::Delta(base::TimeDelta delta_) nit: use an arg name without ...
7 years, 11 months ago (2013-01-17 01:50:33 UTC) #2
Ryan Hamilton
7 years, 11 months ago (2013-01-17 18:44:18 UTC) #3
https://codereview.chromium.org/11961022/diff/1/net/quic/quic_time.cc
File net/quic/quic_time.cc (right):

https://codereview.chromium.org/11961022/diff/1/net/quic/quic_time.cc#newcode14
net/quic/quic_time.cc:14: QuicTime::Delta::Delta(base::TimeDelta delta_)
On 2013/01/17 01:50:33, jar wrote:
> nit: use an arg name without the trailing underscore.

Done.

Powered by Google App Engine
This is Rietveld 408576698