Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Side by Side Diff: net/quic/quic_time_test.cc

Issue 11961022: Remove default constructors for QuicTime and QuicTime::Delta and used static Zero() methods instead… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "net/quic/quic_time.h" 5 #include "net/quic/quic_time.h"
6 #include "net/quic/test_tools/mock_clock.h" 6 #include "net/quic/test_tools/mock_clock.h"
7 #include "testing/gtest/include/gtest/gtest.h" 7 #include "testing/gtest/include/gtest/gtest.h"
8 8
9 namespace net { 9 namespace net {
10 namespace testing { 10 namespace testing {
11 11
12 class QuicTimeDeltaTest : public ::testing::Test { 12 class QuicTimeDeltaTest : public ::testing::Test {
13 protected: 13 protected:
14 }; 14 };
15 15
16 TEST_F(QuicTimeDeltaTest, Zero) { 16 TEST_F(QuicTimeDeltaTest, Zero) {
17 EXPECT_TRUE(QuicTime::Delta().IsZero()); 17 EXPECT_TRUE(QuicTime::Delta::Zero().IsZero());
18 EXPECT_FALSE(QuicTime::Delta::Zero().IsInfinite());
18 EXPECT_FALSE(QuicTime::Delta::FromMilliseconds(1).IsZero()); 19 EXPECT_FALSE(QuicTime::Delta::FromMilliseconds(1).IsZero());
19 } 20 }
20 21
21 TEST_F(QuicTimeDeltaTest, Infinite) { 22 TEST_F(QuicTimeDeltaTest, Infinite) {
22 EXPECT_TRUE(QuicTime::Delta::Infinite().IsInfinite()); 23 EXPECT_TRUE(QuicTime::Delta::Infinite().IsInfinite());
23 EXPECT_FALSE(QuicTime::Delta().IsInfinite()); 24 EXPECT_FALSE(QuicTime::Delta::Zero().IsInfinite());
24 EXPECT_FALSE(QuicTime::Delta::FromMilliseconds(1).IsInfinite()); 25 EXPECT_FALSE(QuicTime::Delta::FromMilliseconds(1).IsInfinite());
25 } 26 }
26 27
27 TEST_F(QuicTimeDeltaTest, FromTo) { 28 TEST_F(QuicTimeDeltaTest, FromTo) {
28 EXPECT_EQ(QuicTime::Delta::FromMilliseconds(1), 29 EXPECT_EQ(QuicTime::Delta::FromMilliseconds(1),
29 QuicTime::Delta::FromMicroseconds(1000)); 30 QuicTime::Delta::FromMicroseconds(1000));
30 EXPECT_EQ(1, QuicTime::Delta::FromMicroseconds(1000).ToMilliseconds()); 31 EXPECT_EQ(1, QuicTime::Delta::FromMicroseconds(1000).ToMilliseconds());
31 EXPECT_EQ(2, QuicTime::Delta::FromMilliseconds(2000).ToSeconds()); 32 EXPECT_EQ(2, QuicTime::Delta::FromMilliseconds(2000).ToSeconds());
32 EXPECT_EQ(1000, QuicTime::Delta::FromMilliseconds(1).ToMicroseconds()); 33 EXPECT_EQ(1000, QuicTime::Delta::FromMilliseconds(1).ToMicroseconds());
33 } 34 }
34 35
35 TEST_F(QuicTimeDeltaTest, Add) { 36 TEST_F(QuicTimeDeltaTest, Add) {
36 EXPECT_EQ(QuicTime::Delta::FromMicroseconds(2000), 37 EXPECT_EQ(QuicTime::Delta::FromMicroseconds(2000),
37 QuicTime::Delta().Add(QuicTime::Delta::FromMilliseconds(2))); 38 QuicTime::Delta::Zero().Add(QuicTime::Delta::FromMilliseconds(2)));
38 } 39 }
39 40
40 TEST_F(QuicTimeDeltaTest, Subtract) { 41 TEST_F(QuicTimeDeltaTest, Subtract) {
41 EXPECT_EQ(QuicTime::Delta::FromMicroseconds(1000), 42 EXPECT_EQ(QuicTime::Delta::FromMicroseconds(1000),
42 QuicTime::Delta::FromMilliseconds(2).Subtract( 43 QuicTime::Delta::FromMilliseconds(2).Subtract(
43 QuicTime::Delta::FromMilliseconds(1))); 44 QuicTime::Delta::FromMilliseconds(1)));
44 } 45 }
45 46
46 class QuicTimeTest : public ::testing::Test { 47 class QuicTimeTest : public ::testing::Test {
47 protected: 48 protected:
48 MockClock clock_; 49 MockClock clock_;
49 }; 50 };
50 51
51 TEST_F(QuicTimeTest, Initialized) { 52 TEST_F(QuicTimeTest, Initialized) {
52 EXPECT_FALSE(QuicTime().IsInitialized()); 53 EXPECT_FALSE(QuicTime::Zero().IsInitialized());
53 EXPECT_TRUE(QuicTime::FromMilliseconds(1).IsInitialized()); 54 EXPECT_TRUE(QuicTime::FromMilliseconds(1).IsInitialized());
54 } 55 }
55 56
56 TEST_F(QuicTimeTest, FromTo) { 57 TEST_F(QuicTimeTest, FromTo) {
57 EXPECT_EQ(QuicTime::FromMilliseconds(1), 58 EXPECT_EQ(QuicTime::FromMilliseconds(1),
58 QuicTime::FromMicroseconds(1000)); 59 QuicTime::FromMicroseconds(1000));
59 EXPECT_EQ(1u, QuicTime::FromMicroseconds(1000).ToMilliseconds()); 60 EXPECT_EQ(1u, QuicTime::FromMicroseconds(1000).ToMilliseconds());
60 EXPECT_EQ(1000u, QuicTime::FromMilliseconds(1).ToMicroseconds()); 61 EXPECT_EQ(1000u, QuicTime::FromMilliseconds(1).ToMicroseconds());
61 } 62 }
62 63
(...skipping 35 matching lines...) Expand 10 before | Expand all | Expand 10 after
98 now = clock_.Now(); 99 now = clock_.Now();
99 100
100 EXPECT_NE(now, time); 101 EXPECT_NE(now, time);
101 102
102 time = time.Add(QuicTime::Delta::FromMilliseconds(1)); 103 time = time.Add(QuicTime::Delta::FromMilliseconds(1));
103 EXPECT_EQ(now, time); 104 EXPECT_EQ(now, time);
104 } 105 }
105 106
106 } // namespace testing 107 } // namespace testing
107 } // namespace net 108 } // namespace net
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698