net/quic/congestion_control/quic_send_scheduler_test.cc - Issue 11961022: Remove default constructors for QuicTime and QuicTime::Delta and used static Zero() methods instead…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/quic/congestion_control/quic_send_scheduler_test.cc

Issue 11961022: Remove default constructors for QuicTime and QuicTime::Delta and used static Zero() methods instead… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « net/quic/congestion_control/quic_receipt_metrics_collector_test.cc ('k') | net/quic/congestion_control/tcp_cubic_sender.cc » ('j') | net/quic/quic_time.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: net/quic/congestion_control/quic_send_scheduler_test.cc

diff --git a/net/quic/congestion_control/quic_send_scheduler_test.cc b/net/quic/congestion_control/quic_send_scheduler_test.cc

index f28a6db18e6b92e84cbc29a07cb7fd9a2bfaf3a6..a59c0e777fad2c6f4c57639f09bb9ad0cfe39635 100644

--- a/net/quic/congestion_control/quic_send_scheduler_test.cc

+++ b/net/quic/congestion_control/quic_send_scheduler_test.cc

@@ -54,7 +54,7 @@ TEST_F(QuicSendSchedulerTest, FixedRatePacing) {

feedback.fix_rate.bitrate_in_bytes_per_second = 100000;

sender_->OnIncomingQuicCongestionFeedbackFrame(feedback);

- QuicTime acc_advance_time;

+ QuicTime acc_advance_time(QuicTime::Zero());

for (int i = 1; i <= 100; ++i) {

EXPECT_TRUE(sender_->TimeUntilSend(false).IsZero());

EXPECT_EQ(kMaxPacketSize, sender_->AvailableCongestionWindow());

@@ -174,7 +174,7 @@ TEST_F(QuicSendSchedulerTest, Pacing) {

feedback.fix_rate.bitrate_in_bytes_per_second = 1000000;

sender_->OnIncomingQuicCongestionFeedbackFrame(feedback);

- QuicTime acc_advance_time;

+ QuicTime acc_advance_time(QuicTime::Zero());

for (int i = 1; i <= 100;) {

EXPECT_TRUE(sender_->TimeUntilSend(false).IsZero());

EXPECT_EQ(kMaxPacketSize * 2, sender_->AvailableCongestionWindow());