Remove default constructors for QuicTime and QuicTime::Delta and used static Zero() methods instead…

net/quic/quic_time.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/quic/quic_time.h"
 
 #include "base/logging.h"
 
 namespace net {
 
 // Highest number of microseconds that DateTimeOffset can hold.
 const int64 kQuicInfiniteTimeUs = GG_INT64_C(0x7fffffffffffffff) / 10;
 
-QuicTime::Delta::Delta()
-    : delta_(base::TimeDelta::FromMicroseconds(0)) {
+QuicTime::Delta::Delta(base::TimeDelta delta_)

[jar (doing other things), 2013/01/17 01:50:33]

nit: use an arg name without the trailing underscore.

[Ryan Hamilton, 2013/01/17 18:44:18]

Done.

+    : delta_(delta_) {
 }
 
-QuicTime::Delta::Delta(base::TimeDelta delta)
-    : delta_(delta) {
+QuicTime::Delta QuicTime::Delta::Zero() {
+  return QuicTime::Delta::FromMicroseconds(0);
 }
 
 QuicTime::Delta QuicTime::Delta::Infinite() {
   return QuicTime::Delta::FromMicroseconds(kQuicInfiniteTimeUs);
 }
 
 bool QuicTime::Delta::IsZero() const {
   return delta_.InMicroseconds() == 0;
 }
 
@@ skipping 24 matching lines @@
 QuicTime::Delta QuicTime::Delta::Add(const Delta& delta) const {
   return QuicTime::Delta::FromMicroseconds(ToMicroseconds() +
                                            delta.ToMicroseconds());
 }
 
 QuicTime::Delta QuicTime::Delta::Subtract(const Delta& delta) const {
   return QuicTime::Delta::FromMicroseconds(ToMicroseconds() -
                                            delta.ToMicroseconds());
 }
 
-
-QuicTime::QuicTime() {
+// static
+QuicTime QuicTime::Zero() {
+  return QuicTime::FromMilliseconds(0);
 }
 
 QuicTime::QuicTime(base::TimeTicks ticks)
     : ticks_(ticks) {
 }
 
 QuicTime QuicTime::FromMilliseconds(int64 time_ms) {
   // DateTime use 100 ns as resolution make sure we don't pass down too high
   // values.
   DCHECK(time_ms < kQuicInfiniteTimeUs / 1000);
@@ skipping 27 matching lines @@
 
 QuicTime QuicTime::Subtract(const Delta& delta) const {
   return QuicTime(ticks_ - delta.delta_);
 }
 
 QuicTime::Delta QuicTime::Subtract(const QuicTime& other) const {
   return QuicTime::Delta(ticks_ - other.ticks_);
 }
 
 }  // namespace gfe_quic