Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(639)

Unified Diff: net/quic/quic_connection_helper_test.cc

Issue 11961022: Remove default constructors for QuicTime and QuicTime::Delta and used static Zero() methods instead… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/quic/quic_connection_helper_test.cc
diff --git a/net/quic/quic_connection_helper_test.cc b/net/quic/quic_connection_helper_test.cc
index 1aa37725741fbf4c01d32a7c31ad4b2dd9842179..03404c0775dc75abaec0c4ab930f255823e1d56f 100644
--- a/net/quic/quic_connection_helper_test.cc
+++ b/net/quic/quic_connection_helper_test.cc
@@ -101,7 +101,7 @@ class QuicConnectionHelperTest : public ::testing::Test {
&random_generator_, socket));
scheduler_ = new testing::StrictMock<MockScheduler>();
EXPECT_CALL(*scheduler_, TimeUntilSend(_)).
- WillRepeatedly(testing::Return(QuicTime::Delta()));
+ WillRepeatedly(testing::Return(QuicTime::Delta::Zero()));
connection_.reset(new TestConnection(guid_, IPEndPoint(), helper_.get()));
connection_->set_visitor(&visitor_);
connection_->SetScheduler(scheduler_);
@@ -199,12 +199,12 @@ TEST_F(QuicConnectionHelperTest, IsSendAlarmSet) {
}
TEST_F(QuicConnectionHelperTest, SetSendAlarm) {
- helper_->SetSendAlarm(QuicTime::Delta());
+ helper_->SetSendAlarm(QuicTime::Delta::Zero());
EXPECT_TRUE(helper_->IsSendAlarmSet());
}
TEST_F(QuicConnectionHelperTest, UnregisterSendAlarmIfRegistered) {
- helper_->SetSendAlarm(QuicTime::Delta());
+ helper_->SetSendAlarm(QuicTime::Delta::Zero());
helper_->UnregisterSendAlarmIfRegistered() ;
EXPECT_FALSE(helper_->IsSendAlarmSet());
}
@@ -317,7 +317,7 @@ TEST_F(QuicConnectionHelperTest, SendSchedulerDelayThenSend) {
// Advance the clock to fire the alarm, and configure the scheduler
// to permit the packet to be sent.
EXPECT_CALL(*scheduler_, TimeUntilSend(false)).WillOnce(testing::Return(
- QuicTime::Delta()));
+ QuicTime::Delta::Zero()));
EXPECT_CALL(visitor_, OnCanWrite()).WillOnce(testing::Return(true));
runner_->RunNextTask();
EXPECT_EQ(0u, connection_->NumQueuedPackets());

Powered by Google App Engine
This is Rietveld 408576698