Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1190793002: Rename UINode to Widget. (Closed)

Created:
5 years, 6 months ago by Hixie
Modified:
5 years, 6 months ago
Reviewers:
abarth-chromium
CC:
abarth-chromium, gregsimon, jackson_old, mojo-reviews_chromium.org, qsr+mojo_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Rename UINode to Widget. Also, move a widget example from examples/raw/ to examples/widgets/ R=abarth@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/940e8502fa8cf93a6f4e3f6603e6c2fa573b2308

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+185 lines, -1065 lines) Patch
D sky/examples/raw/navigation.dart View 1 chunk +0 lines, -34 lines 0 comments Download
M sky/examples/stocks2/lib/stock_app.dart View 1 6 chunks +8 lines, -8 lines 0 comments Download
M sky/examples/stocks2/lib/stock_arrow.dart View 1 chunk +1 line, -1 line 0 comments Download
M sky/examples/stocks2/lib/stock_list.dart View 1 chunk +1 line, -1 line 0 comments Download
M sky/examples/stocks2/lib/stock_menu.dart View 1 chunk +1 line, -1 line 0 comments Download
M sky/examples/stocks2/lib/stock_row.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M sky/examples/widgets/container.dart View 1 chunk +1 line, -1 line 0 comments Download
M sky/examples/widgets/hello_widgets.dart View 1 chunk +1 line, -1 line 0 comments Download
A + sky/examples/widgets/navigation.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
M sky/examples/widgets/sector.dart View 1 6 chunks +7 lines, -7 lines 0 comments Download
M sky/examples/widgets/spinning_mixed.dart View 1 5 chunks +9 lines, -9 lines 0 comments Download
M sky/sdk/lib/editing2/editable_text.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M sky/sdk/lib/editing2/input.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M sky/sdk/lib/widgets/basic.dart View 1 25 chunks +32 lines, -32 lines 0 comments Download
M sky/sdk/lib/widgets/button_base.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M sky/sdk/lib/widgets/drawer.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M sky/sdk/lib/widgets/drawer_header.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M sky/sdk/lib/widgets/fixed_height_scrollable.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M sky/sdk/lib/widgets/floating_action_button.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M sky/sdk/lib/widgets/icon.dart View 1 chunk +1 line, -1 line 0 comments Download
M sky/sdk/lib/widgets/icon_button.dart View 1 2 chunks +2 lines, -2 lines 0 comments Download
M sky/sdk/lib/widgets/ink_well.dart View 1 2 chunks +2 lines, -2 lines 0 comments Download
M sky/sdk/lib/widgets/material.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M sky/sdk/lib/widgets/menu_divider.dart View 1 chunk +1 line, -1 line 0 comments Download
M sky/sdk/lib/widgets/menu_item.dart View 1 3 chunks +3 lines, -3 lines 0 comments Download
M sky/sdk/lib/widgets/modal_overlay.dart View 1 2 chunks +3 lines, -3 lines 0 comments Download
M sky/sdk/lib/widgets/navigator.dart View 2 chunks +5 lines, -5 lines 0 comments Download
M sky/sdk/lib/widgets/popup_menu.dart View 2 chunks +3 lines, -3 lines 0 comments Download
M sky/sdk/lib/widgets/popup_menu_item.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M sky/sdk/lib/widgets/radio.dart View 1 chunk +1 line, -1 line 0 comments Download
M sky/sdk/lib/widgets/raised_button.dart View 2 chunks +3 lines, -3 lines 0 comments Download
M sky/sdk/lib/widgets/scaffold.dart View 1 5 chunks +13 lines, -13 lines 0 comments Download
M sky/sdk/lib/widgets/scrollable.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M sky/sdk/lib/widgets/toggleable.dart View 1 chunk +1 line, -1 line 0 comments Download
M sky/sdk/lib/widgets/tool_bar.dart View 1 chunk +5 lines, -5 lines 0 comments Download
M sky/sdk/lib/widgets/ui_node.dart View 1 1 chunk +0 lines, -846 lines 0 comments Download
A + sky/sdk/lib/widgets/widget.dart View 1 28 chunks +59 lines, -59 lines 0 comments Download
M sky/tests/framework/stocks.dart View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (1 generated)
abarth-chromium
lgtm
5 years, 6 months ago (2015-06-16 18:09:04 UTC) #2
Hixie
5 years, 6 months ago (2015-06-16 18:09:21 UTC) #3
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
940e8502fa8cf93a6f4e3f6603e6c2fa573b2308 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698