Make lint fail builds.

Make lint fail builds.

Fix and suppress a bunch of lint warnings to be able to enable
lint build failing.

TBR=boliu@chromium.org,pauljensen@chromium.org,tedchoc@chromium.org,lambroslambrou@chromium.org,damienv@chromium.org
BUG=501471, 241521, 501591, 501593, 501900, 502030
Committed: https://crrev.com/8db283ac6beb49ad8032a8e6c65e4cc76db65ffd
Cr-Commit-Position: refs/heads/master@{#335371}

[aurimas (slooooooooow), 2015-06-17 20:54:00]

aurimas@chromium.org changed reviewers:
+ newt@chromium.org, yfriedman@chromium.org

[aurimas (slooooooooow), 2015-06-17 20:54:01]

newt and yfriedman: PTAL

[newt (away), 2015-06-17 21:00:47]

https://chromiumcodereview.appspot.com/1190103002/diff/1/build/android/gyp/li...
File build/android/gyp/lint.py (right):

https://chromiumcodereview.appspot.com/1190103002/diff/1/build/android/gyp/li...
build/android/gyp/lint.py:125: return 1
shouldn't we check the value of can_fail_build here? (like we do below)

[aurimas (slooooooooow), 2015-06-17 21:50:24]

https://chromiumcodereview.appspot.com/1190103002/diff/1/build/android/gyp/li...
File build/android/gyp/lint.py (right):

https://chromiumcodereview.appspot.com/1190103002/diff/1/build/android/gyp/li...
build/android/gyp/lint.py:125: return 1
On 2015/06/17 at 21:00:47, newt wrote:
> shouldn't we check the value of can_fail_build here? (like we do below)

Done

[newt (away), 2015-06-17 22:01:02]

lgtm

[aurimas (slooooooooow), 2015-06-17 22:05:58]

aurimas@chromium.org changed reviewers:
+ cjhopman@chromium.org

[aurimas (slooooooooow), 2015-06-17 22:05:58]

+cjhopman for OWNERS review.

[cjhopman, 2015-06-17 22:07:41]

lgtm

https://chromiumcodereview.appspot.com/1190103002/diff/20001/build/android/gy...
File build/android/gyp/lint.py (right):

https://chromiumcodereview.appspot.com/1190103002/diff/20001/build/android/gy...
build/android/gyp/lint.py:124: return 1
I'd suggest using a different value here to distinguish between different types
of failures.

Might not really be necessary since we print the error messages, though.

[aurimas (slooooooooow), 2015-06-17 22:09:52]

The CQ bit was checked by aurimas@chromium.org

[commit-bot: I haz the power, 2015-06-17 22:12:29]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1190103002/20001

[commit-bot: I haz the power, 2015-06-17 22:45:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-06-17 22:45:53]

Try jobs failed on following builders:
  cast_shell_android on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_andr...)

[aurimas (slooooooooow), 2015-06-18 17:46:59]

aurimas@chromium.org changed reviewers:
+ boliu@chromium.org

[aurimas (slooooooooow), 2015-06-18 17:48:01]

aurimas@chromium.org changed reviewers:
+ pauljensen@chromium.org

[aurimas (slooooooooow), 2015-06-18 17:48:33]

aurimas@chromium.org changed reviewers:
+ tedchoc@chromium.org

[aurimas (slooooooooow), 2015-06-18 17:49:19]

aurimas@chromium.org changed reviewers:
+ lambroslambrou@chromium.org

[aurimas (slooooooooow), 2015-06-18 18:40:48]

TBR the following people:
boliu@chromium.org android_webview/
pauljensen@chromium.org components/cronet/android
tedchoc@chromium.org: content/shell/android/ and components/test/android
lambroslambrou@chromium.org: remoting/android/

[boliu, 2015-06-18 18:58:16]

Can you add comment next to TargetApi on what api ling warnings are being
suppressed? Also if an api is only scoped to a method, just add the annotation
to the method, not the class?

[Lambros, 2015-06-18 19:36:09]

LGTM for remoting/android/ - a suppression is appropriate in this case.

[boliu, 2015-06-18 20:26:58]

android_webview lgtm

https://chromiumcodereview.appspot.com/1190103002/diff/80001/android_webview/...
File android_webview/tools/WebViewTelemetryShell/AndroidManifest.xml (right):

https://chromiumcodereview.appspot.com/1190103002/diff/80001/android_webview/...
android_webview/tools/WebViewTelemetryShell/AndroidManifest.xml:12: <uses-sdk
android:minSdkVersion="19" android:targetSdkVersion="19" />
this doesn't exist anymore: https://codereview.chromium.org/1121493004/

[newt (away), 2015-06-18 20:26:59]

lgtm after comments

https://codereview.chromium.org/1190103002/diff/80001/build/android/lint/supp...
File build/android/lint/suppressions.xml (right):

https://codereview.chromium.org/1190103002/diff/80001/build/android/lint/supp...
build/android/lint/suppressions.xml:60: <ignore path="res/drawable/icon.png"/>
add comment explaining the full path

https://codereview.chromium.org/1190103002/diff/80001/build/android/lint/supp...
build/android/lint/suppressions.xml:83: <issue id="ProtectedPermissions"
severity="ignore"/>
file a bug about removing inject events permissions

https://codereview.chromium.org/1190103002/diff/80001/chrome/android/javatest...
File
chrome/android/javatests_shell/src/org/chromium/chrome/browser/notifications/NotificationUIManagerTest.java
(right):

https://codereview.chromium.org/1190103002/diff/80001/chrome/android/javatest...
chrome/android/javatests_shell/src/org/chromium/chrome/browser/notifications/NotificationUIManagerTest.java:40:
@SuppressLint("NewApi")
Is there a bug to fix this? Mention the bug number. Also, it'd be better to
suppress the warning in a smaller scope, e.g. at the method level, if that's not
too messy.

https://codereview.chromium.org/1190103002/diff/80001/components/cronet/andro...
File
components/cronet/android/test/javaperftests/src/org/chromium/net/CronetPerfTestActivity.java
(right):

https://codereview.chromium.org/1190103002/diff/80001/components/cronet/andro...
components/cronet/android/test/javaperftests/src/org/chromium/net/CronetPerfTestActivity.java:215:
@SuppressLint("NewApi")
mention bug to fix this suppression

https://codereview.chromium.org/1190103002/diff/80001/remoting/android/java/A...
File remoting/android/java/AndroidManifest.xml.jinja2 (right):

https://codereview.chromium.org/1190103002/diff/80001/remoting/android/java/A...
remoting/android/java/AndroidManifest.xml.jinja2:30: <!--suppress
AppIndexingError -->
mention bug

[Lambros, 2015-06-18 20:44:32]

https://codereview.chromium.org/1190103002/diff/80001/remoting/android/java/A...
File remoting/android/java/AndroidManifest.xml.jinja2 (right):

https://codereview.chromium.org/1190103002/diff/80001/remoting/android/java/A...
remoting/android/java/AndroidManifest.xml.jinja2:30: <!--suppress
AppIndexingError -->
On 2015/06/18 20:26:59, newt wrote:
> mention bug

FYI, the bug is https://code.google.com/p/chromium/issues/detail?id=501593

[aurimas (slooooooooow), 2015-06-18 21:37:54]

https://chromiumcodereview.appspot.com/1190103002/diff/80001/android_webview/...
File android_webview/tools/WebViewTelemetryShell/AndroidManifest.xml (right):

https://chromiumcodereview.appspot.com/1190103002/diff/80001/android_webview/...
android_webview/tools/WebViewTelemetryShell/AndroidManifest.xml:12: <uses-sdk
android:minSdkVersion="19" android:targetSdkVersion="19" />
On 2015/06/18 at 20:26:58, boliu wrote:
> this doesn't exist anymore: https://codereview.chromium.org/1121493004/

Done

https://chromiumcodereview.appspot.com/1190103002/diff/80001/build/android/li...
File build/android/lint/suppressions.xml (right):

https://chromiumcodereview.appspot.com/1190103002/diff/80001/build/android/li...
build/android/lint/suppressions.xml:60: <ignore path="res/drawable/icon.png"/>
On 2015/06/18 at 20:26:59, newt wrote:
> add comment explaining the full path

Done

https://chromiumcodereview.appspot.com/1190103002/diff/80001/build/android/li...
build/android/lint/suppressions.xml:83: <issue id="ProtectedPermissions"
severity="ignore"/>
On 2015/06/18 at 20:26:59, newt wrote:
> file a bug about removing inject events permissions

Done

https://chromiumcodereview.appspot.com/1190103002/diff/80001/chrome/android/j...
File
chrome/android/javatests_shell/src/org/chromium/chrome/browser/notifications/NotificationUIManagerTest.java
(right):

https://chromiumcodereview.appspot.com/1190103002/diff/80001/chrome/android/j...
chrome/android/javatests_shell/src/org/chromium/chrome/browser/notifications/NotificationUIManagerTest.java:40:
@SuppressLint("NewApi")
On 2015/06/18 at 20:26:59, newt wrote:
> Is there a bug to fix this? Mention the bug number. Also, it'd be better to
suppress the warning in a smaller scope, e.g. at the method level, if that's not
too messy.

Done

https://chromiumcodereview.appspot.com/1190103002/diff/80001/components/crone...
File
components/cronet/android/test/javaperftests/src/org/chromium/net/CronetPerfTestActivity.java
(right):

https://chromiumcodereview.appspot.com/1190103002/diff/80001/components/crone...
components/cronet/android/test/javaperftests/src/org/chromium/net/CronetPerfTestActivity.java:215:
@SuppressLint("NewApi")
On 2015/06/18 at 20:26:59, newt wrote:
> mention bug to fix this suppression

Done

https://chromiumcodereview.appspot.com/1190103002/diff/80001/remoting/android...
File remoting/android/java/AndroidManifest.xml.jinja2 (right):

https://chromiumcodereview.appspot.com/1190103002/diff/80001/remoting/android...
remoting/android/java/AndroidManifest.xml.jinja2:30: <!--suppress
AppIndexingError -->
On 2015/06/18 at 20:44:32, Lambros wrote:
> On 2015/06/18 20:26:59, newt wrote:
> > mention bug
> 
> FYI, the bug is https://code.google.com/p/chromium/issues/detail?id=501593

Done

[aurimas (slooooooooow), 2015-06-18 21:38:03]

The CQ bit was checked by aurimas@chromium.org

[aurimas (slooooooooow), 2015-06-18 21:38:04]

The patchset sent to the CQ was uploaded after l-g-t-m from
cjhopman@chromium.org, newt@chromium.org, boliu@chromium.org,
lambroslambrou@chromium.org
Link to the patchset:
https://chromiumcodereview.appspot.com/1190103002/#ps100001 (title: "newt's
nits")

[commit-bot: I haz the power, 2015-06-18 21:40:11]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1190103002/100001

[aurimas (slooooooooow), 2015-06-18 22:02:01]

The CQ bit was unchecked by aurimas@chromium.org

[aurimas (slooooooooow), 2015-06-18 22:15:21]

aurimas@chromium.org changed reviewers:
+ damienv@chromium.org

[aurimas (slooooooooow), 2015-06-18 22:18:29]

TBR damienv

[aurimas (slooooooooow), 2015-06-18 22:18:34]

The CQ bit was checked by aurimas@chromium.org

[aurimas (slooooooooow), 2015-06-18 22:18:34]

The patchset sent to the CQ was uploaded after l-g-t-m from newt@chromium.org,
boliu@chromium.org, cjhopman@chromium.org, lambroslambrou@chromium.org
Link to the patchset:
https://chromiumcodereview.appspot.com/1190103002/#ps120001 (title: "Few more
lint issues and disable chromecast")

[commit-bot: I haz the power, 2015-06-18 22:18:51]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1190103002/120001

[commit-bot: I haz the power, 2015-06-19 00:57:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-06-19 00:57:55]

Try jobs failed on following builders:
  linux_android_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_android_r...)

[aurimas (slooooooooow), 2015-06-19 01:07:31]

The CQ bit was checked by aurimas@chromium.org

[commit-bot: I haz the power, 2015-06-19 01:09:06]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1190103002/120001

[commit-bot: I haz the power, 2015-06-19 04:28:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-06-19 04:28:26]

Try jobs failed on following builders:
  linux_android_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_android_r...)

[aurimas (slooooooooow), 2015-06-19 19:05:54]

The CQ bit was checked by aurimas@chromium.org

[aurimas (slooooooooow), 2015-06-19 19:05:55]

The patchset sent to the CQ was uploaded after l-g-t-m from newt@chromium.org,
boliu@chromium.org, cjhopman@chromium.org, lambroslambrou@chromium.org
Link to the patchset:
https://chromiumcodereview.appspot.com/1190103002/#ps140001 (title: "Rebase +
test fix")

[commit-bot: I haz the power, 2015-06-19 19:07:57]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1190103002/140001

[damienv1, 2015-06-19 19:13:41]

damienv@chromium.org changed reviewers:
+ gunsch@chromium.org, lcwu@chromium.org

[commit-bot: I haz the power, 2015-06-19 19:43:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-06-19 19:43:16]

Try jobs failed on following builders:
  linux_android_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_android_r...)

[gunsch, 2015-06-19 19:44:33]

gunsch@chromium.org changed reviewers:
- damienv@chromium.org

[gunsch, 2015-06-19 19:44:37]

gunsch@chromium.org changed reviewers:
- lcwu@chromium.org

[gunsch, 2015-06-19 19:45:58]

-damienv1, -lcwu1

lgtm for chromecast

Aside: I'm a little surprised at the name of the "never_lint" variable, since
it's Android-specific, but I guess it was already introduced.

[aurimas (slooooooooow), 2015-06-19 20:06:14]

The CQ bit was checked by aurimas@chromium.org

[aurimas (slooooooooow), 2015-06-19 20:06:14]

The patchset sent to the CQ was uploaded after l-g-t-m from newt@chromium.org,
boliu@chromium.org, gunsch@chromium.org, cjhopman@chromium.org,
lambroslambrou@chromium.org
Link to the patchset:
https://chromiumcodereview.appspot.com/1190103002/#ps160001 (title: "Suppress a
new issue in EnhancedBookmarkEditActivity")

[commit-bot: I haz the power, 2015-06-19 20:07:52]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1190103002/160001

[aurimas (slooooooooow), 2015-06-19 21:11:03]

The CQ bit was checked by aurimas@chromium.org

[aurimas (slooooooooow), 2015-06-19 21:11:03]

The patchset sent to the CQ was uploaded after l-g-t-m from newt@chromium.org,
boliu@chromium.org, gunsch@chromium.org, cjhopman@chromium.org,
lambroslambrou@chromium.org
Link to the patchset:
https://chromiumcodereview.appspot.com/1190103002/#ps180001 (title: "Fix
exported crash for ChromeShellTest")

[commit-bot: I haz the power, 2015-06-19 21:12:47]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1190103002/180001

[commit-bot: I haz the power, 2015-06-19 22:38:59]

Committed patchset #10 (id:180001)

[commit-bot: I haz the power, 2015-06-19 22:39:57]

Patchset 10 (id:??) landed as
https://crrev.com/8db283ac6beb49ad8032a8e6c65e4cc76db65ffd
Cr-Commit-Position: refs/heads/master@{#335371}