chrome/android/javatests_shell/src/org/chromium/chrome/browser/notifications/NotificationUIManagerTest.java - Issue 1190103002: Make lint fail builds.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/javatests_shell/src/org/chromium/chrome/browser/notifications/NotificationUIManagerTest.java

Issue 1190103002: Make lint fail builds. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix exported crash for ChromeShellTest Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/javatests/src/org/chromium/chrome/browser/webapps/WebappModeTest.java ('k') | chrome/android/shell/javatests/AndroidManifest.xml » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/javatests_shell/src/org/chromium/chrome/browser/notifications/NotificationUIManagerTest.java

diff --git a/chrome/android/javatests_shell/src/org/chromium/chrome/browser/notifications/NotificationUIManagerTest.java b/chrome/android/javatests_shell/src/org/chromium/chrome/browser/notifications/NotificationUIManagerTest.java

index 71b1f911ead9911fbd26ddef48ab70e9891dc82f..b8f068c9681f23f3efcea09fe7a820832c4f07e1 100644

--- a/chrome/android/javatests_shell/src/org/chromium/chrome/browser/notifications/NotificationUIManagerTest.java

+++ b/chrome/android/javatests_shell/src/org/chromium/chrome/browser/notifications/NotificationUIManagerTest.java

@@ -6,6 +6,7 @@ package org.chromium.chrome.browser.notifications;

import static org.chromium.base.test.util.ScalableTimeout.scaleTimeout;

+import android.annotation.SuppressLint;

import android.app.Notification;

import android.graphics.Bitmap;

import android.os.Build;

@@ -36,6 +37,8 @@ import java.util.concurrent.TimeoutException;

* Web Notifications are only supported on Android JellyBean and beyond.

+// TODO(peter): remove @SuppressLint once crbug.com/501900 is fixed.

+@SuppressLint("NewApi")

public class NotificationUIManagerTest extends ChromeShellTestBase {

private static final String NOTIFICATION_TEST_PAGE =

TestHttpServerClient.getUrl("chrome/test/data/notifications/android_test.html");