android_webview/javatests/AndroidManifest.xml - Issue 1190103002: Make lint fail builds.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: android_webview/javatests/AndroidManifest.xml

Issue 1190103002: Make lint fail builds. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix exported crash for ChromeShellTest Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | android_webview/test/shell/AndroidManifest.xml » ('j') | no next file with comments »

OLD	NEW
1 <?xml version="1.0" encoding="utf-8"?>	1 <?xml version="1.0" encoding="utf-8"?>

2 <!-- Copyright (c) 2012 The Chromium Authors. All rights reserved. Use of	2 <!-- Copyright (c) 2012 The Chromium Authors. All rights reserved. Use of

3 this source code is governed by a BSD-style license that can be found	3 this source code is governed by a BSD-style license that can be found

4 in the LICENSE file. -->	4 in the LICENSE file. -->

5 <manifest xmlns:android="http://schemas.android.com/apk/res/android"	5 <manifest xmlns:android="http://schemas.android.com/apk/res/android"

6 package="org.chromium.android_webview.test">	6 package="org.chromium.android_webview.test">

7 <!-- TODO(boliu): Change minSdkVersion to 19 when bots no longer try	7 <uses-sdk android:minSdkVersion="19" android:targetSdkVersion="21" />

8 to install webview apks on < K devices. crbug.com/474374 -->

9 <uses-sdk android:minSdkVersion="16" android:targetSdkVersion="21" />

10 <instrumentation android:name="org.chromium.base.test.BaseInstrumentationTes tRunner"	8 <instrumentation android:name="org.chromium.base.test.BaseInstrumentationTes tRunner"

11 android:targetPackage="org.chromium.android_webview.shell"	9 android:targetPackage="org.chromium.android_webview.shell"

12 android:label="Tests for org.chromium.android_webview"/>	10 android:label="Tests for org.chromium.android_webview"/>

13 <uses-permission android:name="android.permission.RUN_INSTRUMENTATION" />	11 <uses-permission android:name="android.permission.RUN_INSTRUMENTATION" />

14 <uses-permission android:name="android.permission.ACCESS_MOCK_LOCATION" />	12 <uses-permission android:name="android.permission.ACCESS_MOCK_LOCATION" />

15 <uses-permission android:name="android.permission.READ_LOGS"/>	13 <uses-permission android:name="android.permission.READ_LOGS"/>

16 <uses-permission android:name="android.permission.WAKE_LOCK" />	14 <uses-permission android:name="android.permission.WAKE_LOCK" />

17 <!-- We add an application tag here just so that we can indicate that this	15 <!-- We add an application tag here just so that we can indicate that this

18 package needs to link against the android.test library, which is	16 package needs to link against the android.test library, which is

19 needed when building test cases. -->	17 needed when building test cases. -->

20 <application android:hardwareAccelerated="false">	18 <application android:hardwareAccelerated="false">

21 <uses-library android:name="android.test.runner" />	19 <uses-library android:name="android.test.runner" />

22 <activity android:name="org.chromium.test.broker.OnDeviceInstrumentation Broker"	20 <activity android:name="org.chromium.test.broker.OnDeviceInstrumentation Broker"

23 android:exported="true"/>	21 android:exported="true"/>

24 </application>	22 </application>

25 </manifest>	23 </manifest>

OLD	NEW