Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(935)

Unified Diff: chrome/android/javatests/src/org/chromium/chrome/browser/TabsTest.java

Issue 1190103002: Make lint fail builds. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix exported crash for ChromeShellTest Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/javatests/src/org/chromium/chrome/browser/TabsTest.java
diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/TabsTest.java b/chrome/android/javatests/src/org/chromium/chrome/browser/TabsTest.java
index e7aff1e69004987f9511eb3584e54f266760d4fa..7bb2d8b68b7af699dd06a2cbfc6c81f4e3a84f85 100644
--- a/chrome/android/javatests/src/org/chromium/chrome/browser/TabsTest.java
+++ b/chrome/android/javatests/src/org/chromium/chrome/browser/TabsTest.java
@@ -65,6 +65,7 @@ import org.chromium.content.common.ContentSwitches;
import org.chromium.content_public.browser.WebContents;
import org.chromium.content_public.browser.WebContentsObserver;
+import java.util.Locale;
import java.util.concurrent.Callable;
import java.util.concurrent.TimeUnit;
import java.util.concurrent.TimeoutException;
@@ -233,7 +234,7 @@ public class TabsTest extends ChromeTabbedActivityTestBase {
@Override
public boolean isSatisfied() {
Tab tab = getActivity().getCurrentTabModel().getTabAt(1);
- String title = tab.getTitle().toLowerCase();
+ String title = tab.getTitle().toLowerCase(Locale.US);
String expectedTitle = "new tab";
return title.startsWith(expectedTitle);
}
@@ -680,7 +681,8 @@ public class TabsTest extends ChromeTabbedActivityTestBase {
for (int i = 1; i < count; i++) {
float y = getLayoutTabInStackXY(false, i)[1];
assertTrue(
- String.format("Tab %d's final draw Y, %f, should exceed the view height, %f.",
+ String.format(Locale.US,
+ "Tab %d's final draw Y, %f, should exceed the view height, %f.",
i, y, mTabsViewHeightDp),
y >= mTabsViewHeightDp);
}
@@ -703,7 +705,8 @@ public class TabsTest extends ChromeTabbedActivityTestBase {
for (int i = 1; i < count; i++) {
float x = getLayoutTabInStackXY(false, i)[0];
assertTrue(
- String.format("Tab %d's final draw X, %f, should exceed the view width, %f.",
+ String.format(Locale.US,
+ "Tab %d's final draw X, %f, should exceed the view width, %f.",
i, x, mTabsViewWidthDp),
x >= mTabsViewWidthDp);
}

Powered by Google App Engine
This is Rietveld 408576698