Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Side by Side Diff: build/android/lint/suppressions.xml

Issue 1190103002: Make lint fail builds. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: set android_webview to use minsdk 19 Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 <?xml version="1.0" encoding="utf-8"?> 1 <?xml version="1.0" encoding="utf-8"?>
2 <lint> 2 <lint>
3 <!-- 3 <!--
4 STOP! It looks like you want to suppress some lint errors: 4 STOP! It looks like you want to suppress some lint errors:
5 - Have you tried identifing the offending patch? 5 - Have you tried identifing the offending patch?
6 Ask the author for a fix and/or revert the patch. 6 Ask the author for a fix and/or revert the patch.
7 - It is preferred to add suppressions in the code instead of 7 - It is preferred to add suppressions in the code instead of
8 sweeping it under the rug here. See: 8 sweeping it under the rug here. See:
9 9
10 http://developer.android.com/tools/debugging/improving-w-lint.html 10 http://developer.android.com/tools/debugging/improving-w-lint.html
(...skipping 39 matching lines...) Expand 10 before | Expand all | Expand 10 after
50 <ignore path="chrome/android/java/res/drawable-xxhdpi"/> 50 <ignore path="chrome/android/java/res/drawable-xxhdpi"/>
51 <ignore path="chrome/android/java/res/drawable-xxxhdpi"/> 51 <ignore path="chrome/android/java/res/drawable-xxxhdpi"/>
52 <ignore path="ui/android/java/res/drawable-xxhdpi"/> 52 <ignore path="ui/android/java/res/drawable-xxhdpi"/>
53 <ignore path="ui/android/java/res/drawable-xxxhdpi"/> 53 <ignore path="ui/android/java/res/drawable-xxxhdpi"/>
54 <ignore regexp=".*: reader_mode_bar_background.9.png, tabs_moved_htc.png, ta bs_moved_nexus.png, tabs_moved_samsung.png$"/> 54 <ignore regexp=".*: reader_mode_bar_background.9.png, tabs_moved_htc.png, ta bs_moved_nexus.png, tabs_moved_samsung.png$"/>
55 </issue> 55 </issue>
56 <!-- It is OK for content_shell_apk and chrome_shell_apk to have missing asset s. --> 56 <!-- It is OK for content_shell_apk and chrome_shell_apk to have missing asset s. -->
57 <issue id="IconLocation"> 57 <issue id="IconLocation">
58 <ignore path="content/shell/android/java/res/"/> 58 <ignore path="content/shell/android/java/res/"/>
59 <ignore path="chrome/android/shell/res/"/> 59 <ignore path="chrome/android/shell/res/"/>
60 <ignore path="res/drawable/icon.png"/>
newt (away) 2015/06/18 20:26:59 add comment explaining the full path
aurimas (slooooooooow) 2015/06/18 21:37:54 Done
61 <ignore path="remoting/android/java/res"/>
60 </issue> 62 </issue>
61 <issue id="InconsistentLayout" severity="ignore"/> 63 <issue id="InconsistentLayout" severity="ignore"/>
62 <issue id="InflateParams" severity="ignore"/> 64 <issue id="InflateParams" severity="ignore"/>
63 <issue id="MissingApplicationIcon" severity="ignore"/> 65 <issue id="MissingApplicationIcon" severity="ignore"/>
64 <issue id="MissingRegistered" severity="ignore"/> 66 <issue id="MissingRegistered" severity="ignore"/>
65 <issue id="MissingVersion"> 67 <issue id="MissingVersion">
66 <ignore path="AndroidManifest.xml"/> 68 <ignore path="AndroidManifest.xml"/>
67 </issue> 69 </issue>
68 <issue id="InlinedApi" severity="ignore"/> 70 <issue id="InlinedApi" severity="ignore"/>
69 <issue id="NewApi"> 71 <issue id="NewApi">
70 <ignore regexp="Attribute `paddingStart` referenced here can result in a cra sh on some specific devices older than API 17"/> 72 <ignore regexp="Attribute `paddingStart` referenced here can result in a cra sh on some specific devices older than API 17"/>
71 <ignore path="org/chromium/base/AnimationFrameTimeHistogram$Recorder.class"/ > 73 <ignore path="org/chromium/base/AnimationFrameTimeHistogram$Recorder.class"/ >
72 <ignore path="org/chromium/base/JavaHandlerThread.class"/> 74 <ignore path="org/chromium/base/JavaHandlerThread.class"/>
73 <ignore path="org/chromium/base/SysUtils.class"/> 75 <ignore path="org/chromium/base/SysUtils.class"/>
74 <ignore path="org/chromium/chrome/browser/TtsPlatformImpl.class"/> 76 <ignore path="org/chromium/chrome/browser/TtsPlatformImpl.class"/>
75 <ignore path="org/chromium/chrome/browser/TtsPlatformImpl$*.class"/> 77 <ignore path="org/chromium/chrome/browser/TtsPlatformImpl$*.class"/>
76 </issue> 78 </issue>
77 <issue id="OldTargetApi"> 79 <issue id="OldTargetApi">
78 <ignore path="AndroidManifest.xml"/> 80 <ignore path="AndroidManifest.xml"/>
79 </issue> 81 </issue>
80 <issue id="Overdraw" severity="ignore"/> 82 <issue id="Overdraw" severity="ignore"/>
83 <issue id="ProtectedPermissions" severity="ignore"/>
newt (away) 2015/06/18 20:26:59 file a bug about removing inject events permission
aurimas (slooooooooow) 2015/06/18 21:37:54 Done
81 <issue id="Recycle" severity="ignore"/> 84 <issue id="Recycle" severity="ignore"/>
82 <issue id="Registered" severity="ignore"/> 85 <issue id="Registered" severity="ignore"/>
83 <issue id="RtlCompat" severity="ignore"/> 86 <issue id="RtlCompat" severity="ignore"/>
84 <issue id="RtlEnabled" severity="ignore"/> 87 <issue id="RtlEnabled" severity="ignore"/>
85 <issue id="RtlSymmetry" severity="ignore"/> 88 <issue id="RtlSymmetry" severity="ignore"/>
86 <issue id="SdCardPath"> 89 <issue id="SdCardPath">
87 <ignore path="content/public/android/java/src/org/chromium/content/browser/M ediaResourceGetter.java"/> 90 <ignore path="content/public/android/java/src/org/chromium/content/browser/M ediaResourceGetter.java"/>
88 </issue> 91 </issue>
89 <issue id="SetJavaScriptEnabled" severity="ignore"/> 92 <issue id="SetJavaScriptEnabled" severity="ignore"/>
90 <issue id="UnusedResources"> 93 <issue id="UnusedResources">
91 <!-- 94 <!--
92 TODO(pkotwicz): Re-enable after the chrome_java and chrome_staging_java 95 TODO(pkotwicz): Re-enable after the chrome_java and chrome_staging_java
93 targets have been merged. crbug.com/484934 96 targets have been merged. crbug.com/484934
94 --> 97 -->
95 <ignore path="chrome/android/java/res" /> 98 <ignore path="chrome/android/java/res" />
99 <ignore path="content/shell/android/shell_apk/res/layout/content_shell_activ ity.xml" />
100 <ignore path="content/shell/android/shell_apk/res/values/strings.xml" />
96 </issue> 101 </issue>
97 <issue id="SignatureOrSystemPermissions" severity="ignore"/> 102 <issue id="SignatureOrSystemPermissions" severity="ignore"/>
98 <issue id="UnusedAttribute" severity="ignore"/> 103 <issue id="UnusedAttribute" severity="ignore"/>
99 <issue id="ViewConstructor" severity="ignore"/> 104 <issue id="ViewConstructor" severity="ignore"/>
100 <issue id="WrongCall" severity="ignore"/> 105 <issue id="WrongCall" severity="ignore"/>
101 </lint> 106 </lint>
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698