Add support for creating texture backed images where Skia will delete the texture.

Add support for creating texture backed images where Skia will delete the texture.

Committed: https://skia.googlesource.com/skia/+/6dc6f5f4a153d33ed91565cb3cd397a310a937d0

[bsalomon, 2015-06-17 21:14:10]

bsalomon@google.com changed reviewers:
+ reed@google.com, robertphillips@google.com

[bsalomon, 2015-06-17 21:18:55]

+Florin

[robertphillips, 2015-06-18 14:18:49]

lgtm + nits & questions

https://codereview.chromium.org/1187523005/diff/20001/include/gpu/GrGpuResour...
File include/gpu/GrGpuResource.h (right):

https://codereview.chromium.org/1187523005/diff/20001/include/gpu/GrGpuResour...
include/gpu/GrGpuResource.h:145: 
Would a set of orthogonal flags make any of this easier:

kCached|kUncached
kSkiaFrees|kSkiaDoesntFree
kInternal|kExternal

?

https://codereview.chromium.org/1187523005/diff/20001/include/gpu/GrGpuResour...
include/gpu/GrGpuResource.h:167: /**
add a space after '.' ?

https://codereview.chromium.org/1187523005/diff/20001/src/gpu/GrTest.cpp
File src/gpu/GrTest.cpp (right):

https://codereview.chromium.org/1187523005/diff/20001/src/gpu/GrTest.cpp#newc...
src/gpu/GrTest.cpp:90: }
Is it worth differentiating the counts for the borrowed vs. owned external
resources?

https://codereview.chromium.org/1187523005/diff/20001/tests/ResourceCacheTest...
File tests/ResourceCacheTest.cpp (right):

https://codereview.chromium.org/1187523005/diff/20001/tests/ResourceCacheTest...
tests/ResourceCacheTest.cpp:234: context->resetContext();
Do we care about cleaning up borrowed?

[reed1, 2015-06-18 15:07:42]

api lgtm

[bsalomon, 2015-06-18 15:19:37]

Added a default param to keep chrome compiling and removed the param from
GrTextureProvider::createWrappedRenderTarget().

https://codereview.chromium.org/1187523005/diff/20001/include/gpu/GrGpuResour...
File include/gpu/GrGpuResource.h (right):

https://codereview.chromium.org/1187523005/diff/20001/include/gpu/GrGpuResour...
include/gpu/GrGpuResource.h:145: 
On 2015/06/18 14:18:49, robertphillips wrote:
> Would a set of orthogonal flags make any of this easier:
> 
> kCached|kUncached
> kSkiaFrees|kSkiaDoesntFree
> kInternal|kExternal
> 
> ?

Maybe, but I sort of like the explicit flags for interactive debugging. I can
just look at the flag and know where it came from instead of thinking about a
bitfield and what paths set which bits. If it got yet more complicated I think
we'd have to move to flags. Also, I think those flags aren't really orthogonal
(kCached | kSkiaDoesnFree) is illegal as is (kInternal | kSkiaDoesnFree) (at
least for now).

https://codereview.chromium.org/1187523005/diff/20001/include/gpu/GrGpuResour...
include/gpu/GrGpuResource.h:167: /**
On 2015/06/18 14:18:49, robertphillips wrote:
> add a space after '.' ?

Done.

https://codereview.chromium.org/1187523005/diff/20001/src/gpu/GrTest.cpp
File src/gpu/GrTest.cpp (right):

https://codereview.chromium.org/1187523005/diff/20001/src/gpu/GrTest.cpp#newc...
src/gpu/GrTest.cpp:90: }
On 2015/06/18 14:18:49, robertphillips wrote:
> Is it worth differentiating the counts for the borrowed vs. owned external
> resources?

Done.

https://codereview.chromium.org/1187523005/diff/20001/tests/ResourceCacheTest...
File tests/ResourceCacheTest.cpp (right):

https://codereview.chromium.org/1187523005/diff/20001/tests/ResourceCacheTest...
tests/ResourceCacheTest.cpp:234: context->resetContext();
On 2015/06/18 14:18:49, robertphillips wrote:
> Do we care about cleaning up borrowed?

Done.

[bsalomon, 2015-06-18 16:06:04]

The CQ bit was checked by bsalomon@google.com

[bsalomon, 2015-06-18 16:06:04]

The patchset sent to the CQ was uploaded after l-g-t-m from
robertphillips@google.com, reed@google.com
Link to the patchset: https://codereview.chromium.org/1187523005/#ps70001
(title: "Add default param to support Chrome's current callers")

[commit-bot: I haz the power, 2015-06-18 16:06:24]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1187523005/70001

[commit-bot: I haz the power, 2015-06-18 16:12:21]

Committed patchset #5 (id:70001) as
https://skia.googlesource.com/skia/+/6dc6f5f4a153d33ed91565cb3cd397a310a937d0