Issue 11833010: Expose liveedit compile error data in SDK

Issue 11833010: Expose liveedit compile error data in SDK (Closed)

Created:
7 years, 11 months ago by Peter Rybin

Modified:
7 years, 11 months ago

Reviewers:
apavlov

CC:
chromedevtools-codereview_googlegroups.com

Base URL:
https://chromedevtools.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

Expose liveedit compile error data in SDK Committed: http://code.google.com/p/chromedevtools/source/detail?r=1130

Patch Set 3 : fcr #

Created: 7 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+153 lines, -14 lines)			Patch
M	plugins/org.chromium.debug.ui/src/org/chromium/debug/ui/actions/PushChangesAction.java	View		1 chunk	+1 line, -1 line	0 comments	Download
M	plugins/org.chromium.debug.ui/src/org/chromium/debug/ui/liveedit/PreviewLoader.java	View		1 chunk	+1 line, -1 line	0 comments	Download
M	plugins/org.chromium.debug.ui/src/org/chromium/debug/ui/liveedit/PushChangesWizard.java	View		1 chunk	+1 line, -1 line	0 comments	Download
M	plugins/org.chromium.sdk.wipbackend.dev/src/org/chromium/sdk/internal/wip/WipScriptImpl.java	View		2 chunks	+4 lines, -1 line	0 comments	Download
M	plugins/org.chromium.sdk/src-dynamic-impl/parser/org/chromium/sdk/internal/v8native/protocol/input/V8DynamicParser.java	View	1 2	1 chunk	+3 lines, -0 lines	0 comments	Download
M	plugins/org.chromium.sdk/src/org/chromium/sdk/UpdatableScript.java	View	1 2	2 chunks	+35 lines, -1 line	0 comments	Download
M	plugins/org.chromium.sdk/src/org/chromium/sdk/internal/protocolparser/EnumValueCondition.java	View		2 chunks	+4 lines, -0 lines	0 comments	Download
M	plugins/org.chromium.sdk/src/org/chromium/sdk/internal/v8native/ScriptImpl.java	View	1 2	2 chunks	+57 lines, -1 line	0 comments	Download
M	plugins/org.chromium.sdk/src/org/chromium/sdk/internal/v8native/V8CommandCallbackBase.java	View		2 chunks	+5 lines, -5 lines	0 comments	Download
M	plugins/org.chromium.sdk/src/org/chromium/sdk/internal/v8native/protocol/input/ChangeLiveBody.java	View	1 2	2 chunks	+37 lines, -0 lines	0 comments	Download
M	plugins/org.chromium.sdk/src/org/chromium/sdk/internal/v8native/protocol/input/FailedCommandResponse.java	View		2 chunks	+5 lines, -3 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

apavlov

https://codereview.chromium.org/11833010/diff/2001/plugins/org.chromium.sdk/src/org/chromium/sdk/UpdatableScript.java File plugins/org.chromium.sdk/src/org/chromium/sdk/UpdatableScript.java (right): https://codereview.chromium.org/11833010/diff/2001/plugins/org.chromium.sdk/src/org/chromium/sdk/UpdatableScript.java#newcode138 plugins/org.chromium.sdk/src/org/chromium/sdk/UpdatableScript.java:138: * Describeds failure caused by compile error. Describes https://codereview.chromium.org/11833010/diff/2001/plugins/org.chromium.sdk/src/org/chromium/sdk/internal/v8native/protocol/input/ChangeLiveBody.java ...

7 years, 11 months ago (2013-01-21 14:25:02 UTC) #2

Peter Rybin

7 years, 11 months ago (2013-01-21 16:01:32 UTC) #4

Message was sent while issue was closed.

https://codereview.chromium.org/11833010/diff/2001/plugins/org.chromium.sdk/s...
File plugins/org.chromium.sdk/src/org/chromium/sdk/UpdatableScript.java (right):

https://codereview.chromium.org/11833010/diff/2001/plugins/org.chromium.sdk/s...
plugins/org.chromium.sdk/src/org/chromium/sdk/UpdatableScript.java:138: *
Describeds failure caused by compile error.
On 2013/01/21 14:25:02, apavlov wrote:
> Describes

Done.

https://codereview.chromium.org/11833010/diff/2001/plugins/org.chromium.sdk/s...
File
plugins/org.chromium.sdk/src/org/chromium/sdk/internal/v8native/protocol/input/ChangeLiveBody.java
(right):

https://codereview.chromium.org/11833010/diff/2001/plugins/org.chromium.sdk/s...
plugins/org.chromium.sdk/src/org/chromium/sdk/internal/v8native/protocol/input/ChangeLiveBody.java:41:
interface Position {
On 2013/01/21 14:25:02, apavlov wrote:
> Sounds like an inappropriate name. This resembles a Range much more (and we
name
> it that way in WebCore), otherwise it's going to confuse and frustrate users.

Done.

https://codereview.chromium.org/11833010/diff/2001/plugins/org.chromium.sdk/s...
plugins/org.chromium.sdk/src/org/chromium/sdk/internal/v8native/protocol/input/ChangeLiveBody.java:47:
interface PointPosition {
On 2013/01/21 14:25:02, apavlov wrote:
> Why "PointPosition"? A plain "Position" would work fine.

Done.

https://codereview.chromium.org/11833010/diff/2001/plugins/org.chromium.sdk/s...
plugins/org.chromium.sdk/src/org/chromium/sdk/internal/v8native/protocol/input/ChangeLiveBody.java:48:
long position();
On 2013/01/21 14:25:02, apavlov wrote:
> Is this actually an offset()? We should be very careful when inventing new
type
> names.

Done.

Expand Messages | Collapse Messages