Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(284)

Side by Side Diff: plugins/org.chromium.sdk.wipbackend.dev/src/org/chromium/sdk/internal/wip/WipScriptImpl.java

Issue 11833010: Expose liveedit compile error data in SDK (Closed) Base URL: https://chromedevtools.googlecode.com/svn/trunk
Patch Set: fcr Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 package org.chromium.sdk.internal.wip; 5 package org.chromium.sdk.internal.wip;
6 6
7 import java.util.List; 7 import java.util.List;
8 8
9 import org.chromium.sdk.RelayOk; 9 import org.chromium.sdk.RelayOk;
10 import org.chromium.sdk.Script; 10 import org.chromium.sdk.Script;
11 import org.chromium.sdk.SyncCallback; 11 import org.chromium.sdk.SyncCallback;
12 import org.chromium.sdk.UpdatableScript;
12 import org.chromium.sdk.internal.ScriptBase; 13 import org.chromium.sdk.internal.ScriptBase;
13 import org.chromium.sdk.internal.liveeditprotocol.LiveEditProtocolParserAccess; 14 import org.chromium.sdk.internal.liveeditprotocol.LiveEditProtocolParserAccess;
14 import org.chromium.sdk.internal.liveeditprotocol.LiveEditResult; 15 import org.chromium.sdk.internal.liveeditprotocol.LiveEditResult;
15 import org.chromium.sdk.internal.protocolparser.JsonProtocolParseException; 16 import org.chromium.sdk.internal.protocolparser.JsonProtocolParseException;
16 import org.chromium.sdk.internal.wip.protocol.input.debugger.CallFrameValue; 17 import org.chromium.sdk.internal.wip.protocol.input.debugger.CallFrameValue;
17 import org.chromium.sdk.internal.wip.protocol.input.debugger.SetScriptSourceData ; 18 import org.chromium.sdk.internal.wip.protocol.input.debugger.SetScriptSourceData ;
18 import org.chromium.sdk.internal.wip.protocol.output.debugger.SetScriptSourcePar ams; 19 import org.chromium.sdk.internal.wip.protocol.output.debugger.SetScriptSourcePar ams;
19 import org.chromium.sdk.util.GenericCallback; 20 import org.chromium.sdk.util.GenericCallback;
20 import org.chromium.sdk.util.RelaySyncCallback; 21 import org.chromium.sdk.util.RelaySyncCallback;
21 22
(...skipping 33 matching lines...) Expand 10 before | Expand all | Expand 10 after
55 new GenericCallback<SetScriptSourceData>() { 56 new GenericCallback<SetScriptSourceData>() {
56 @Override 57 @Override
57 public void success(SetScriptSourceData value) { 58 public void success(SetScriptSourceData value) {
58 RelayOk relayOk = 59 RelayOk relayOk =
59 possiblyUpdateCallFrames(preview, value, updateCallback, guard.getRe lay()); 60 possiblyUpdateCallFrames(preview, value, updateCallback, guard.getRe lay());
60 guard.discharge(relayOk); 61 guard.discharge(relayOk);
61 } 62 }
62 63
63 @Override 64 @Override
64 public void failure(Exception exception) { 65 public void failure(Exception exception) {
65 updateCallback.failure(exception.getMessage()); 66 // TODO: provide failure details when supported by protocol.
67 UpdatableScript.Failure failure = UpdatableScript.Failure.UNSPECIFIED;
68 updateCallback.failure(exception.getMessage(), failure);
66 } 69 }
67 }; 70 };
68 71
69 WipCommandProcessor commandProcessor = scriptManager.getTabImpl().getCommand Processor(); 72 WipCommandProcessor commandProcessor = scriptManager.getTabImpl().getCommand Processor();
70 return commandProcessor.send(params, commandCallback, guard.asSyncCallback() ); 73 return commandProcessor.send(params, commandCallback, guard.asSyncCallback() );
71 } 74 }
72 75
73 private RelayOk possiblyUpdateCallFrames(boolean preview, final SetScriptSourc eData data, 76 private RelayOk possiblyUpdateCallFrames(boolean preview, final SetScriptSourc eData data,
74 final UpdateCallback updateCallback, RelaySyncCallback relay) { 77 final UpdateCallback updateCallback, RelaySyncCallback relay) {
75 78
(...skipping 30 matching lines...) Expand all
106 LiveEditProtocolParserAccess.get().parseLiveEditResult(result.getUnd erlyingObject()); 109 LiveEditProtocolParserAccess.get().parseLiveEditResult(result.getUnd erlyingObject());
107 } catch (JsonProtocolParseException e) { 110 } catch (JsonProtocolParseException e) {
108 throw new RuntimeException("Failed to parse LiveEdit response", e); 111 throw new RuntimeException("Failed to parse LiveEdit response", e);
109 } 112 }
110 ChangeDescription wrappedChangeDescription = 113 ChangeDescription wrappedChangeDescription =
111 UpdateResultParser.wrapChangeDescription(liveEditResult); 114 UpdateResultParser.wrapChangeDescription(liveEditResult);
112 updateCallback.success(null, wrappedChangeDescription); 115 updateCallback.success(null, wrappedChangeDescription);
113 } 116 }
114 } 117 }
115 } 118 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698