Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(935)

Unified Diff: plugins/org.chromium.sdk.wipbackend.dev/src/org/chromium/sdk/internal/wip/WipScriptImpl.java

Issue 11833010: Expose liveedit compile error data in SDK (Closed) Base URL: https://chromedevtools.googlecode.com/svn/trunk
Patch Set: fcr Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: plugins/org.chromium.sdk.wipbackend.dev/src/org/chromium/sdk/internal/wip/WipScriptImpl.java
diff --git a/plugins/org.chromium.sdk.wipbackend.dev/src/org/chromium/sdk/internal/wip/WipScriptImpl.java b/plugins/org.chromium.sdk.wipbackend.dev/src/org/chromium/sdk/internal/wip/WipScriptImpl.java
index c46d11ebfe1f7e08f400460164f3a1567dbe1a68..2f90f82f79f867f9e6839207e64a55161e530cab 100644
--- a/plugins/org.chromium.sdk.wipbackend.dev/src/org/chromium/sdk/internal/wip/WipScriptImpl.java
+++ b/plugins/org.chromium.sdk.wipbackend.dev/src/org/chromium/sdk/internal/wip/WipScriptImpl.java
@@ -9,6 +9,7 @@ import java.util.List;
import org.chromium.sdk.RelayOk;
import org.chromium.sdk.Script;
import org.chromium.sdk.SyncCallback;
+import org.chromium.sdk.UpdatableScript;
import org.chromium.sdk.internal.ScriptBase;
import org.chromium.sdk.internal.liveeditprotocol.LiveEditProtocolParserAccess;
import org.chromium.sdk.internal.liveeditprotocol.LiveEditResult;
@@ -62,7 +63,9 @@ class WipScriptImpl extends ScriptBase<String> {
@Override
public void failure(Exception exception) {
- updateCallback.failure(exception.getMessage());
+ // TODO: provide failure details when supported by protocol.
+ UpdatableScript.Failure failure = UpdatableScript.Failure.UNSPECIFIED;
+ updateCallback.failure(exception.getMessage(), failure);
}
};

Powered by Google App Engine
This is Rietveld 408576698