plugins/org.chromium.sdk/src/org/chromium/sdk/internal/v8native/V8CommandCallbackBase.java - Issue 11833010: Expose liveedit compile error data in SDK

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: plugins/org.chromium.sdk/src/org/chromium/sdk/internal/v8native/V8CommandCallbackBase.java

Issue 11833010: Expose liveedit compile error data in SDK (Closed) Base URL: https://chromedevtools.googlecode.com/svn/trunk

Patch Set: fcr Created 7 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « plugins/org.chromium.sdk/src/org/chromium/sdk/internal/v8native/ScriptImpl.java ('k') | plugins/org.chromium.sdk/src/org/chromium/sdk/internal/v8native/protocol/input/ChangeLiveBody.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: plugins/org.chromium.sdk/src/org/chromium/sdk/internal/v8native/V8CommandCallbackBase.java

diff --git a/plugins/org.chromium.sdk/src/org/chromium/sdk/internal/v8native/V8CommandCallbackBase.java b/plugins/org.chromium.sdk/src/org/chromium/sdk/internal/v8native/V8CommandCallbackBase.java

index 3de1f8006d4cb082b8b5c723199922e905a0f99f..44d2d64a7b684430b2e222d957611938b3cc8288 100644

--- a/plugins/org.chromium.sdk/src/org/chromium/sdk/internal/v8native/V8CommandCallbackBase.java

+++ b/plugins/org.chromium.sdk/src/org/chromium/sdk/internal/v8native/V8CommandCallbackBase.java

@@ -15,6 +15,11 @@ import org.chromium.sdk.internal.v8native.protocol.input.SuccessCommandResponse;

public abstract class V8CommandCallbackBase implements V8CommandProcessor.V8HandlerCallback {

public abstract void success(SuccessCommandResponse successResponse);

+ @Override

+ final public void failure(String message) {

+ failure(message, null);

+ }

public abstract void failure(String message, FailedCommandResponse.ErrorDetails errorDetails);

@Override

@@ -27,9 +32,4 @@ public abstract class V8CommandCallbackBase implements V8CommandProcessor.V8Hand

success(successResponse);

}

- @Override

- final public void failure(String message) {

- failure(message, null);

- }

}