Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(161)

Issue 1175243009: [Sync] Rename SyncEnabledAndLoggedIn() to CanStartSync(). (Closed)

Created:
5 years, 6 months ago by maxbogue
Modified:
5 years, 6 months ago
CC:
chromium-reviews, tim+watch_chromium.org, extensions-reviews_chromium.org, michaelpg+watch-options_chromium.org, Matt Giuca, zea+watch_chromium.org, tapted, tfarina, vabr+watchlist_chromium.org, maxbogue+watch_chromium.org, browser-components-watch_chromium.org, dbeam+watch-options_chromium.org, maniscalco+watch_chromium.org, pvalenzuela+watch_chromium.org, plaree+watch_chromium.org, estade+watch_chromium.org, chromium-apps-reviews_chromium.org, gcasto+watchlist_chromium.org, James Su, rouslan+autofillwatch_chromium.org, mkwst+watchlist-passwords_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Sync] Rename SyncEnabledAndLoggedIn() to CanStartSync(). This is part of an effort to clean up sync's state interface. CanStartSync more accurately represents the conceptual implication of the conditions that the method checks. Note that at present, this does not map perfectly to what is actually checked when sync tries to start, but that will happen in an upcoming change. BUG=495192 TBR=sdefresne,pkasting Committed: https://crrev.com/96b7d277ef548f5f3d5f050efe229a719c2389fb Cr-Commit-Position: refs/heads/master@{#334545}

Patch Set 1 #

Patch Set 2 : Fix Android build. #

Patch Set 3 : Update comment & mark const. #

Patch Set 4 : Missed a const transition. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -66 lines) Patch
M chrome/browser/android/contextualsearch/contextual_search_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/android/most_visited_sites.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/android/precache/precache_launcher.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/autocomplete/chrome_autocomplete_provider_client.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/external_pref_loader.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/password_manager/password_store_factory.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/profile_sync_service.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/profile_sync_service.cc View 1 2 1 chunk +2 lines, -6 lines 0 comments Download
M chrome/browser/sync/profile_sync_service_android.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/profile_sync_service_mock.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/sync_startup_tracker.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/sync_startup_tracker_unittest.cc View 6 chunks +6 lines, -12 lines 0 comments Download
M chrome/browser/ui/app_list/search/suggestions/suggestions_search_provider.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/options/sync_setup_handler_unittest.cc View 11 chunks +11 lines, -22 lines 0 comments Download
M components/autofill/core/browser/options_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/autofill/core/browser/options_util_unittest.cc View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M components/sync_driver/fake_sync_service.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M components/sync_driver/fake_sync_service.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M components/sync_driver/sync_service.h View 1 2 1 chunk +2 lines, -6 lines 0 comments Download
M ios/chrome/browser/sync/sync_setup_service.cc View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 17 (6 generated)
maxbogue
Hey Nicolas, here's another refactoring CL. PTAL!
5 years, 6 months ago (2015-06-12 18:06:25 UTC) #3
vabr (Chromium)
chrome/browser/password_manager/password_store_factory.cc LGTM.
5 years, 6 months ago (2015-06-14 18:53:24 UTC) #5
maxbogue
Adding the following reviewers, who will be TBR'd if necessary: bauerb: chrome/browser/android/contextualsearch/contextual_search_delegate.cc chrome/browser/android/most_visited_sites.cc chrome/browser/android/precache/precache_launcher.cc benwells: ...
5 years, 6 months ago (2015-06-15 17:26:18 UTC) #7
Bernhard Bauer
Android LGTM
5 years, 6 months ago (2015-06-15 17:29:01 UTC) #8
Peter Kasting
LGTM
5 years, 6 months ago (2015-06-15 20:58:47 UTC) #10
Nicolas Zea
lgtm
5 years, 6 months ago (2015-06-15 23:30:14 UTC) #11
benwells
lgtm
5 years, 6 months ago (2015-06-16 00:20:44 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1175243009/60001
5 years, 6 months ago (2015-06-16 01:08:51 UTC) #14
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 6 months ago (2015-06-16 03:00:08 UTC) #15
commit-bot: I haz the power
Patchset 4 (id:??) landed as https://crrev.com/96b7d277ef548f5f3d5f050efe229a719c2389fb Cr-Commit-Position: refs/heads/master@{#334545}
5 years, 6 months ago (2015-06-16 03:01:08 UTC) #16
sdefresne
5 years, 6 months ago (2015-06-16 14:07:25 UTC) #17
Message was sent while issue was closed.
components/autofill & ios/chrome lgtm

Powered by Google App Engine
This is Rietveld 408576698