chrome/browser/password_manager/password_store_factory.cc - Issue 1175243009: [Sync] Rename SyncEnabledAndLoggedIn() to CanStartSync().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/password_manager/password_store_factory.cc

Issue 1175243009: [Sync] Rename SyncEnabledAndLoggedIn() to CanStartSync(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Missed a const transition. Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/password_manager/password_store_factory.cc

diff --git a/chrome/browser/password_manager/password_store_factory.cc b/chrome/browser/password_manager/password_store_factory.cc

index 76bc7115ec70059aa0fe8e7c0c6253e86dd8755a..fb7f474d923200a18b0c6479bfe7aa8cd0ae0219 100644

--- a/chrome/browser/password_manager/password_store_factory.cc

+++ b/chrome/browser/password_manager/password_store_factory.cc

@@ -98,7 +98,7 @@ bool ShouldAffiliationBasedMatchingBeActive(Profile* profile) {

ProfileSyncService* profile_sync_service =

ProfileSyncServiceFactory::GetInstance()->GetForProfile(profile);

return profile_sync_service &&

- profile_sync_service->IsSyncEnabledAndLoggedIn() &&

+ profile_sync_service->CanSyncStart() &&

profile_sync_service->IsSyncActive() &&

profile_sync_service->GetPreferredDataTypes().Has(syncer::PASSWORDS) &&

!profile_sync_service->IsUsingSecondaryPassphrase();

« no previous file with comments | « chrome/browser/extensions/external_pref_loader.cc ('k') | chrome/browser/sync/profile_sync_service.h » ('j') | no next file with comments »