chrome/browser/extensions/external_pref_loader.cc - Issue 1175243009: [Sync] Rename SyncEnabledAndLoggedIn() to CanStartSync().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/external_pref_loader.cc

Issue 1175243009: [Sync] Rename SyncEnabledAndLoggedIn() to CanStartSync(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Missed a const transition. Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/autocomplete/chrome_autocomplete_provider_client.cc ('k') | chrome/browser/password_manager/password_store_factory.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/external_pref_loader.cc

diff --git a/chrome/browser/extensions/external_pref_loader.cc b/chrome/browser/extensions/external_pref_loader.cc

index 472d1858bba8abbda7d0ad8b9c44c86497612998..d5509276e88abbc69f2c79aec33d98ddd3eedaba 100644

--- a/chrome/browser/extensions/external_pref_loader.cc

+++ b/chrome/browser/extensions/external_pref_loader.cc

@@ -127,7 +127,7 @@ void ExternalPrefLoader::StartLoading() {

ProfileSyncService* service =

ProfileSyncServiceFactory::GetForProfile(profile_);

DCHECK(service);

- if (service->IsSyncEnabledAndLoggedIn() &&

+ if (service->CanSyncStart() &&

(service->HasSyncSetupCompleted() ||

browser_defaults::kSyncAutoStarts)) {

service->AddObserver(this);

@@ -150,7 +150,7 @@ void ExternalPrefLoader::OnStateChanged() {

ProfileSyncService* service =

ProfileSyncServiceFactory::GetForProfile(profile_);

DCHECK(service);

- if (!service->IsSyncEnabledAndLoggedIn()) {

+ if (!service->CanSyncStart()) {

PostLoadAndRemoveObservers();

}