chrome/browser/sync/profile_sync_service_android.cc - Issue 1175243009: [Sync] Rename SyncEnabledAndLoggedIn() to CanStartSync().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/sync/profile_sync_service_android.cc

Issue 1175243009: [Sync] Rename SyncEnabledAndLoggedIn() to CanStartSync(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Missed a const transition. Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/sync/profile_sync_service_android.cc

diff --git a/chrome/browser/sync/profile_sync_service_android.cc b/chrome/browser/sync/profile_sync_service_android.cc

index ba0630135b632b96155075b8f07ca8b17296fbb5..c35abb769ab8902d7ae61be8223bed4f453d3ca2 100644

--- a/chrome/browser/sync/profile_sync_service_android.cc

+++ b/chrome/browser/sync/profile_sync_service_android.cc

@@ -176,7 +176,7 @@ void ProfileSyncServiceAndroid::SignInSync(JNIEnv* env, jobject) {

// should start up automatically as long as it has credentials). This can

// happen normally if (for example) the user closes and reopens the sync

// settings window quickly during initial startup.

- if (sync_service_->IsSyncEnabledAndLoggedIn() &&

+ if (sync_service_->CanSyncStart() &&

sync_service_->IsOAuthRefreshTokenAvailable() &&

sync_service_->HasSyncSetupCompleted()) {

return;

« no previous file with comments | « chrome/browser/sync/profile_sync_service.cc ('k') | chrome/browser/sync/profile_sync_service_mock.h » ('j') | no next file with comments »