chrome/browser/autocomplete/chrome_autocomplete_provider_client.cc - Issue 1175243009: [Sync] Rename SyncEnabledAndLoggedIn() to CanStartSync().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/autocomplete/chrome_autocomplete_provider_client.cc

Issue 1175243009: [Sync] Rename SyncEnabledAndLoggedIn() to CanStartSync(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Missed a const transition. Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/autocomplete/chrome_autocomplete_provider_client.cc

diff --git a/chrome/browser/autocomplete/chrome_autocomplete_provider_client.cc b/chrome/browser/autocomplete/chrome_autocomplete_provider_client.cc

index 2bd10f638947b81dc45402731494aee1aa567350..d1a5cc55a541ed86222c4766220e8db3fbe0b39b 100644

--- a/chrome/browser/autocomplete/chrome_autocomplete_provider_client.cc

+++ b/chrome/browser/autocomplete/chrome_autocomplete_provider_client.cc

@@ -86,7 +86,7 @@ bool ChromeAutocompleteProviderClient::TabSyncEnabledAndUnencrypted() {

ProfileSyncServiceFactory::GetInstance()->GetForProfile(profile_);

sync_driver::SyncPrefs sync_prefs(profile_->GetPrefs());

return service &&

- service->IsSyncEnabledAndLoggedIn() &&

+ service->CanSyncStart() &&

sync_prefs.GetPreferredDataTypes(syncer::UserTypes()).Has(

syncer::PROXY_TABS) &&

!service->GetEncryptedDataTypes().Has(syncer::SESSIONS);

« no previous file with comments | « chrome/browser/android/precache/precache_launcher.cc ('k') | chrome/browser/extensions/external_pref_loader.cc » ('j') | no next file with comments »