cc: Rename visible_content_rect and content stuff on quads.

cc: Rename visible_content_rect and content stuff on quads.

This renames visible_content_rect to visible_layer_rect. And for
SharedQuadState renames the transforms and rects to no longer refer
to "content" and instead refer to the space the the DrawQuad rects.

R=enne, vmpstr
TBR=dcheng
BUG=413479
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Committed: https://crrev.com/64767d90be693c7e98efd1a0794bb567b46262ec
Cr-Commit-Position: refs/heads/master@{#335172}

[danakj, 2015-06-18 20:53:28]

Bikesheds welcome on the SharedQuadState member names

[enne (OOO), 2015-06-18 21:02:16]

https://codereview.chromium.org/1175113010/diff/20001/cc/layers/picture_layer...
File cc/layers/picture_layer_impl.cc (right):

https://codereview.chromium.org/1175113010/diff/20001/cc/layers/picture_layer...
cc/layers/picture_layer_impl.cc:346:
append_quads_data->checkerboarded_visible_layer_area +=
This is not true.  I think this in the space of max content scale, which is a
bit weird.  Can you file a bug for making this be more real? Or maybe making
them be in layer space?

https://codereview.chromium.org/1175113010/diff/20001/cc/quads/shared_quad_st...
File cc/quads/shared_quad_state.cc (left):

https://codereview.chromium.org/1175113010/diff/20001/cc/quads/shared_quad_st...
cc/quads/shared_quad_state.cc:52:
MathUtil::AddToTracedValue("layer_visible_content_rect", visible_content_rect,
Are these used by trace viewer?

[enne (OOO), 2015-06-18 21:02:44]

Quad names seem good enough to me.  I'm sad about the duplicate "quad" in a quad
class, but maybe it's worth clarifying our spaces.  vmpstr, what do you think?

[danakj, 2015-06-18 21:06:35]

PTAL

https://codereview.chromium.org/1175113010/diff/20001/cc/layers/picture_layer...
File cc/layers/picture_layer_impl.cc (right):

https://codereview.chromium.org/1175113010/diff/20001/cc/layers/picture_layer...
cc/layers/picture_layer_impl.cc:346:
append_quads_data->checkerboarded_visible_layer_area +=
On 2015/06/18 21:02:15, enne wrote:
> This is not true.  I think this in the space of max content scale, which is a
> bit weird.  Can you file a bug for making this be more real? Or maybe making
> them be in layer space?

I reverted this name and will file a bug.

https://codereview.chromium.org/1175113010/diff/20001/cc/quads/shared_quad_st...
File cc/quads/shared_quad_state.cc (left):

https://codereview.chromium.org/1175113010/diff/20001/cc/quads/shared_quad_st...
cc/quads/shared_quad_state.cc:52:
MathUtil::AddToTracedValue("layer_visible_content_rect", visible_content_rect,
On 2015/06/18 21:02:15, enne wrote:
> Are these used by trace viewer?

Oops I was trying to leave these unchanged cuz ya.

[danakj, 2015-06-18 21:27:32]

danakj@chromium.org changed reviewers:
+ sky@chromium.org

[danakj, 2015-06-18 21:27:33]

+sky for components/ content/ and mojo/. (Renaming some fields.)

[danakj, 2015-06-18 21:28:03]

danakj@chromium.org changed reviewers:
+ boliu@chromium.org

[danakj, 2015-06-18 21:28:03]

+boliu for android_webview/ (renaming some fields)

[boliu, 2015-06-18 21:29:46]

On 2015/06/18 21:28:03, danakj wrote:
> +boliu for android_webview/ (renaming some fields)

rs lgtm

[boliu, 2015-06-18 21:29:46]

On 2015/06/18 21:28:03, danakj wrote:
> +boliu for android_webview/ (renaming some fields)

rs lgtm

[danakj, 2015-06-18 21:31:58]

danakj@chromium.org changed reviewers:
+ dcheng@chromium.org

[danakj, 2015-06-18 21:31:59]

+dcheng for cc_messages (renaming some fields)

[sky, 2015-06-18 23:28:16]

LGTM

[danakj, 2015-06-18 23:55:15]

The CQ bit was checked by danakj@chromium.org

[danakj, 2015-06-18 23:55:15]

The patchset sent to the CQ was uploaded after l-g-t-m from boliu@chromium.org
Link to the patchset: https://codereview.chromium.org/1175113010/#ps30072
(title: "rename-visible-content-rect: moreandroid")

[commit-bot: I haz the power, 2015-06-18 23:57:13]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1175113010/30072

[commit-bot: I haz the power, 2015-06-19 00:10:57]

Committed patchset #8 (id:30072)

[commit-bot: I haz the power, 2015-06-19 00:11:32]

Patchset 8 (id:??) landed as
https://crrev.com/64767d90be693c7e98efd1a0794bb567b46262ec
Cr-Commit-Position: refs/heads/master@{#335172}

[dcheng, 2015-06-19 03:11:38]

rs lgtm for renaming changes in ipc