[Document mode] Force more pathways to use the TabDelegate instead

[Document mode] Force more pathways to use the TabDelegate instead

Stops classes from using ChromeLauncherActivity.launchDocumentInstance()
to create their tabs, and changes them to use the TabDelegate instead.
This is a step towards simplifying the rats nest of parameters being fed
into the function.

BUG=451453
Committed: https://crrev.com/b89eb0347c7be3dbf7f66421d09689e2d1bd4674
Cr-Commit-Position: refs/heads/master@{#335574}

[gone, 2015-06-18 22:41:02]

dfalcantara@chromium.org changed reviewers:
+ mariakhomenko@chromium.org, peter@chromium.org

[gone, 2015-06-18 22:41:03]

Peter: Please check that the ChromeServiceTabLauncher changes look alright.

Maria: Everything but.

Relying on the current Document*Tests to make sure that I haven't borked
anything.

https://codereview.chromium.org/1174263006/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/tabmodel/document/DocumentTabModelSelector.java
(left):

https://codereview.chromium.org/1174263006/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/tabmodel/document/DocumentTabModelSelector.java:187:
PendingDocumentData params = null;
Turns out most of this is useless when you move to using the TabDelegate.

https://codereview.chromium.org/1174263006/diff/1/chrome/android/java_staging...
File
chrome/android/java_staging/src/org/chromium/chrome/browser/ChromeServiceTabLauncher.java
(left):

https://codereview.chromium.org/1174263006/diff/1/chrome/android/java_staging...
chrome/android/java_staging/src/org/chromium/chrome/browser/ChromeServiceTabLauncher.java:40:
PendingDocumentData data = new PendingDocumentData();
PendingDocumentData creation is pushed into Document classes so callers don't
have to worry about it.

https://codereview.chromium.org/1174263006/diff/1/chrome/android/java_staging...
File
chrome/android/java_staging/src/org/chromium/chrome/browser/document/TabDelegateImpl.java
(left):

https://codereview.chromium.org/1174263006/diff/1/chrome/android/java_staging...
chrome/android/java_staging/src/org/chromium/chrome/browser/document/TabDelegateImpl.java:120:
DocumentMetricIds.STARTED_BY_CHROME_HOME_RECENT_TABS,
Switches to using the transition type that's passed in.

[gone, 2015-06-22 17:26:04]

dfalcantara@chromium.org changed reviewers:
+ mlamouri@chromium.org
- peter@chromium.org

[gone, 2015-06-22 17:26:05]

Swapping in Mounir.

[mlamouri (slow - plz ping), 2015-06-22 17:33:44]

lgtm

[Maria, 2015-06-22 21:00:29]

lgtm

https://codereview.chromium.org/1174263006/diff/20001/chrome/android/java_sta...
File
chrome/android/java_staging/src/org/chromium/chrome/browser/document/TabDelegateImpl.java
(right):

https://codereview.chromium.org/1174263006/diff/20001/chrome/android/java_sta...
chrome/android/java_staging/src/org/chromium/chrome/browser/document/TabDelegateImpl.java:146:
params.requestId = requestId;
I would just stick that into the list of things to set above after referrer.

[gone, 2015-06-22 22:06:26]

https://codereview.chromium.org/1174263006/diff/20001/chrome/android/java_sta...
File
chrome/android/java_staging/src/org/chromium/chrome/browser/document/TabDelegateImpl.java
(right):

https://codereview.chromium.org/1174263006/diff/20001/chrome/android/java_sta...
chrome/android/java_staging/src/org/chromium/chrome/browser/document/TabDelegateImpl.java:146:
params.requestId = requestId;
On 2015/06/22 21:00:29, Maria wrote:
> I would just stick that into the list of things to set above after referrer.

Done.

[gone, 2015-06-22 22:06:30]

The CQ bit was checked by dfalcantara@chromium.org

[gone, 2015-06-22 22:06:30]

The patchset sent to the CQ was uploaded after l-g-t-m from
mariakhomenko@chromium.org, mlamouri@chromium.org
Link to the patchset: https://codereview.chromium.org/1174263006/#ps60001
(title: "Null guarding")

[commit-bot: I haz the power, 2015-06-22 22:07:39]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1174263006/60001

[commit-bot: I haz the power, 2015-06-22 22:18:03]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-06-22 22:20:08]

Patchset 4 (id:??) landed as
https://crrev.com/b89eb0347c7be3dbf7f66421d09689e2d1bd4674
Cr-Commit-Position: refs/heads/master@{#335574}