chrome/android/java_staging/src/org/chromium/chrome/browser/document/ChromeLauncherActivity.java - Issue 1174263006: [Document mode] Force more pathways to use the TabDelegate instead

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java_staging/src/org/chromium/chrome/browser/document/ChromeLauncherActivity.java

Issue 1174263006: [Document mode] Force more pathways to use the TabDelegate instead (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Null guarding Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java_staging/src/org/chromium/chrome/browser/ChromeServiceTabLauncher.java ('k') | chrome/android/java_staging/src/org/chromium/chrome/browser/document/DocumentActivity.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java_staging/src/org/chromium/chrome/browser/document/ChromeLauncherActivity.java

diff --git a/chrome/android/java_staging/src/org/chromium/chrome/browser/document/ChromeLauncherActivity.java b/chrome/android/java_staging/src/org/chromium/chrome/browser/document/ChromeLauncherActivity.java

index 0279df46fb48d79f527de8866fc53850e77f06e9..38102cf33f9a9ccfc16b25491f0e562fe0ca8c71 100644

--- a/chrome/android/java_staging/src/org/chromium/chrome/browser/document/ChromeLauncherActivity.java

+++ b/chrome/android/java_staging/src/org/chromium/chrome/browser/document/ChromeLauncherActivity.java

@@ -429,7 +429,8 @@ public class ChromeLauncherActivity extends Activity

}

/**

- * Starts a Document for the given URL.

+ * Starts a Document for the given URL. Generally, you should be using the TabCreator attached

+ * to the DocumentTabModelSelector.

* NOTE: this method adds trusted intent extra to authenticate that Chrome set the

* EXTRA_PAGE_TRANSITION_TYPE extra which we only want Chrome to do.