Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3096)

Unified Diff: chrome/android/java_staging/src/org/chromium/chrome/browser/document/DocumentTab.java

Issue 1174263006: [Document mode] Force more pathways to use the TabDelegate instead (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Null guarding Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java_staging/src/org/chromium/chrome/browser/document/DocumentTab.java
diff --git a/chrome/android/java_staging/src/org/chromium/chrome/browser/document/DocumentTab.java b/chrome/android/java_staging/src/org/chromium/chrome/browser/document/DocumentTab.java
index b7cfce391690febd8e303ef7bd72aa5fbd00d339..6993080ed0d5590a56da6236cb25ad1c315520be 100644
--- a/chrome/android/java_staging/src/org/chromium/chrome/browser/document/DocumentTab.java
+++ b/chrome/android/java_staging/src/org/chromium/chrome/browser/document/DocumentTab.java
@@ -184,22 +184,17 @@ public class DocumentTab extends ChromeTab {
@Override
public void onOpenInNewTab(String url, Referrer referrer) {
- PendingDocumentData params = new PendingDocumentData();
- params.referrer = referrer;
- ChromeLauncherActivity.launchDocumentInstance(
- getWindowAndroid().getActivity().get(), isIncognito(),
- ChromeLauncherActivity.LAUNCH_MODE_AFFILIATED, url,
- DocumentMetricIds.STARTED_BY_CONTEXT_MENU,
- PageTransition.AUTO_TOPLEVEL, params);
+ LoadUrlParams params = new LoadUrlParams(url, PageTransition.AUTO_TOPLEVEL);
+ params.setReferrer(referrer);
+ mActivity.getTabModelSelector().openNewTab(params,
+ TabLaunchType.FROM_LONGPRESS_BACKGROUND, DocumentTab.this, isIncognito());
}
@Override
public void onOpenInNewIncognitoTab(String url) {
- ChromeLauncherActivity.launchDocumentInstance(
- getWindowAndroid().getActivity().get(), true,
- ChromeLauncherActivity.LAUNCH_MODE_FOREGROUND,
- url, DocumentMetricIds.STARTED_BY_CONTEXT_MENU,
- PageTransition.AUTO_TOPLEVEL, null);
+ mActivity.getTabModelSelector().openNewTab(
+ new LoadUrlParams(url, PageTransition.AUTO_TOPLEVEL),
+ TabLaunchType.FROM_LONGPRESS_FOREGROUND, DocumentTab.this, true);
}
@Override

Powered by Google App Engine
This is Rietveld 408576698