Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8560)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/tabmodel/document/DocumentTabModelImpl.java

Issue 1174263006: [Document mode] Force more pathways to use the TabDelegate instead (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Null guarding Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/tabmodel/document/DocumentTabModelSelector.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/src/org/chromium/chrome/browser/tabmodel/document/DocumentTabModelImpl.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/tabmodel/document/DocumentTabModelImpl.java b/chrome/android/java/src/org/chromium/chrome/browser/tabmodel/document/DocumentTabModelImpl.java
index c716c54b998d694f26713db665b7710329218317..ff4ef6173e8fd177fde84ece6a1d6c46c4c90029 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/tabmodel/document/DocumentTabModelImpl.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/tabmodel/document/DocumentTabModelImpl.java
@@ -339,9 +339,10 @@ public class DocumentTabModelImpl extends TabModelJniBridge implements DocumentT
// session restore tabs. Differs from TabModelImpl because we explicitly open tabs in the
// foreground -- opening tabs in affiliated mode is disallowed by ChromeLauncherActivity
// when a WebContents has already been created.
- return getTabDelegate(isIncognito).createTabWithWebContents(
+ getTabDelegate(isIncognito).createTabWithWebContents(
webContents, parentTabId, TabLaunchType.FROM_LONGPRESS_FOREGROUND,
DocumentMetricIds.STARTED_BY_CHROME_HOME_RECENT_TABS);
+ return null;
}
@Override
« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/tabmodel/document/DocumentTabModelSelector.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698