Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3464)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/tabmodel/document/DocumentTabModelSelector.java

Issue 1174263006: [Document mode] Force more pathways to use the TabDelegate instead (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Null guarding Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/tabmodel/document/DocumentTabModelSelector.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/tabmodel/document/DocumentTabModelSelector.java b/chrome/android/java/src/org/chromium/chrome/browser/tabmodel/document/DocumentTabModelSelector.java
index 48e4db45dc53a633c1ef17bfacd9a47f50843faf..59f9989e1f265bab4555a0f61bcb4b5a51f7f248 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/tabmodel/document/DocumentTabModelSelector.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/tabmodel/document/DocumentTabModelSelector.java
@@ -184,22 +184,8 @@ public class DocumentTabModelSelector extends TabModelSelectorBase
@Override
public Tab openNewTab(LoadUrlParams loadUrlParams, TabLaunchType type, Tab parent,
boolean incognito) {
- PendingDocumentData params = null;
- if (loadUrlParams.getPostData() != null
- || loadUrlParams.getVerbatimHeaders() != null
- || loadUrlParams.getReferrer() != null) {
- params = new PendingDocumentData();
- params.postData = loadUrlParams.getPostData();
- params.extraHeaders = loadUrlParams.getVerbatimHeaders();
- params.referrer = loadUrlParams.getReferrer();
- }
-
- Activity parentActivity =
- parent == null ? null : parent.getWindowAndroid().getActivity().get();
-
TabDelegate delegate = getTabCreator(incognito);
- Tab parentTab = delegate.getActivityTab(mActivityDelegate, parentActivity);
- delegate.createNewTab(loadUrlParams, type, parentTab);
+ delegate.createNewTab(loadUrlParams, type, parent);
return null;
}

Powered by Google App Engine
This is Rietveld 408576698