Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1174203002: Clip inkwell splash around the floating action button (Closed)

Created:
5 years, 6 months ago by jackson
Modified:
5 years, 6 months ago
Reviewers:
abarth-chromium, Hixie
CC:
abarth-chromium, gregsimon, jackson_old, mojo-reviews_chromium.org, qsr+mojo_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 5

Patch Set 2 : rebase and apply code review feedback #

Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -13 lines) Patch
M sky/engine/core/painting/Canvas.h View 2 chunks +3 lines, -1 line 0 comments Download
M sky/engine/core/painting/Canvas.cpp View 1 chunk +16 lines, -0 lines 0 comments Download
M sky/engine/core/painting/Canvas.idl View 2 chunks +4 lines, -1 line 0 comments Download
M sky/engine/core/painting/CanvasPath.h View 1 chunk +5 lines, -0 lines 0 comments Download
M sky/engine/core/painting/Path.idl View 1 1 chunk +1 line, -0 lines 0 comments Download
M sky/sdk/lib/framework/components2/fixed_height_scrollable.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M sky/sdk/lib/framework/components2/floating_action_button.dart View 1 1 chunk +8 lines, -4 lines 0 comments Download
M sky/sdk/lib/framework/fn2.dart View 1 1 chunk +12 lines, -4 lines 0 comments Download
M sky/sdk/lib/framework/rendering/box.dart View 1 2 chunks +18 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
jackson
5 years, 6 months ago (2015-06-10 22:28:24 UTC) #1
abarth-chromium
LGTM https://codereview.chromium.org/1174203002/diff/1/sky/engine/core/painting/Path.idl File sky/engine/core/painting/Path.idl (right): https://codereview.chromium.org/1174203002/diff/1/sky/engine/core/painting/Path.idl#newcode12 sky/engine/core/painting/Path.idl:12: void addOval(Rect oval); Indent https://codereview.chromium.org/1174203002/diff/1/sky/sdk/lib/framework/components2/floating_action_button.dart File sky/sdk/lib/framework/components2/floating_action_button.dart (right): ...
5 years, 6 months ago (2015-06-10 22:33:44 UTC) #2
Hixie
lgtm try bots are red because you have merge conflicts. https://codereview.chromium.org/1174203002/diff/1/sky/sdk/lib/framework/fn2.dart File sky/sdk/lib/framework/fn2.dart (right): https://codereview.chromium.org/1174203002/diff/1/sky/sdk/lib/framework/fn2.dart#newcode394 ...
5 years, 6 months ago (2015-06-10 22:34:17 UTC) #4
jackson
5 years, 6 months ago (2015-06-10 22:57:30 UTC) #5
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
8fef4785eb0aa1bc02a7ad80dfd50048bac9e4c2 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698