sky/sdk/lib/framework/components2/fixed_height_scrollable.dart - Issue 1174203002: Clip inkwell splash around the floating action button

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sky/sdk/lib/framework/components2/fixed_height_scrollable.dart

Issue 1174203002: Clip inkwell splash around the floating action button (Closed) Base URL: git@github.com:domokit/mojo.git@master

Patch Set: rebase and apply code review feedback Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sky/sdk/lib/framework/components2/fixed_height_scrollable.dart

diff --git a/sky/sdk/lib/framework/components2/fixed_height_scrollable.dart b/sky/sdk/lib/framework/components2/fixed_height_scrollable.dart

index 93fba3c42c700d03fd873786c718632b685d675d..95392802c7dfdb8d0624ffa08a62e3d90c0cc1d3 100644

--- a/sky/sdk/lib/framework/components2/fixed_height_scrollable.dart

+++ b/sky/sdk/lib/framework/components2/fixed_height_scrollable.dart

@@ -68,7 +68,7 @@ abstract class FixedHeightScrollable extends Scrollable {

return new SizeObserver(

callback: _handleSizeChanged,

- child: new Clip(

+ child: new ClipRect(

child: new DecoratedBox(

decoration: const BoxDecoration(

backgroundColor: const Color(0xFFFFFFFF)