Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Unified Diff: sky/sdk/lib/framework/components2/floating_action_button.dart

Issue 1174203002: Clip inkwell splash around the floating action button (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: rebase and apply code review feedback Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sky/sdk/lib/framework/components2/fixed_height_scrollable.dart ('k') | sky/sdk/lib/framework/fn2.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/sdk/lib/framework/components2/floating_action_button.dart
diff --git a/sky/sdk/lib/framework/components2/floating_action_button.dart b/sky/sdk/lib/framework/components2/floating_action_button.dart
index d660b332bc7b7b770e58c257fe169e7ec7653a68..45680a8b7094af3ca5edeb299e7ab4abdbc61c43 100644
--- a/sky/sdk/lib/framework/components2/floating_action_button.dart
+++ b/sky/sdk/lib/framework/components2/floating_action_button.dart
@@ -40,10 +40,14 @@ class FloatingActionButton extends Component {
paint.setDrawLooper(builder.build());
canvas.drawCircle(radius, radius, radius, paint);
},
- child: new Container(
- width: _kSize,
- height: _kSize,
- child: new InkWell(children: children))),
+ child: new ClipOval(
+ child: new Container(
+ width: _kSize,
+ height: _kSize,
+ child: new InkWell(children: children)
+ )
+ )
+ ),
level: level);
}
« no previous file with comments | « sky/sdk/lib/framework/components2/fixed_height_scrollable.dart ('k') | sky/sdk/lib/framework/fn2.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698