Rename platform-independent ConstrainedWindow types to WebContentsModalDialog types (part 1)

Rename platform-independent ConstrainedWindow types to WebContentsModalDialog types (part 1).

This CL addresses method renames.  Class and file renames are handled in a second CL to preserve file history: https://codereview.chromium.org/11633052.

Renaming/replacement of platform-dependent ConstrainedWindow types and functional changes specified in the associated bug will be addressed in later CLs.

No functional changes are intended in this CL.

R=sky@chromium.org
BUG=157161
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=174517

[Mike Wittman, 2012-12-19 21:22:13]

This is the next step in the ConstrainedWindow API rework that Ben is looking
for.  My proposed implementation plan is here:
https://docs.google.com/a/google.com/document/d/1ssiNC7UHKpC1bHUphb7EwQL_FaPg...;
this is step 2.

Sailesh, please review chrome/browser/ui/cocoa/*
Scott, please review everything else.

[sail, 2012-12-19 21:36:41]

cocoa/* LGTM!

[sky, 2012-12-19 23:22:38]

https://codereview.chromium.org/11647017/diff/1/chrome/browser/ui/web_content...
File chrome/browser/ui/web_contents_modal_dialog.h (right):

https://codereview.chromium.org/11647017/diff/1/chrome/browser/ui/web_content...
chrome/browser/ui/web_contents_modal_dialog.h:17: class WebContentsModalDialog {
I believe this is going to lose history. Any chance you could rename the class
first, then the methods so that we preserve history? Maybe you can get it to
work with playing with --similarity or whatever it is.

https://codereview.chromium.org/11647017/diff/1/chrome/browser/ui/web_content...
chrome/browser/ui/web_contents_modal_dialog.h:36: virtual gfx::NativeWindow
GetNativeWindow();
why isn't this pure virtual, in fact I would tend to make all of these pure
virtual.

[Mike Wittman, 2012-12-21 01:55:14]

https://codereview.chromium.org/11647017/diff/1/chrome/browser/ui/web_content...
File chrome/browser/ui/web_contents_modal_dialog.h (right):

https://codereview.chromium.org/11647017/diff/1/chrome/browser/ui/web_content...
chrome/browser/ui/web_contents_modal_dialog.h:17: class WebContentsModalDialog {
On 2012/12/19 23:22:38, sky wrote:
> I believe this is going to lose history. Any chance you could rename the class
> first, then the methods so that we preserve history? Maybe you can get it to
> work with playing with --similarity or whatever it is.

It was easier for me to do the reverse given the order in which I made the
original changes.  I've peeled off the file and class renames in patch set 2,
and created a second CL with those changes at
https://codereview.chromium.org/11633052.

https://codereview.chromium.org/11647017/diff/1/chrome/browser/ui/web_content...
chrome/browser/ui/web_contents_modal_dialog.h:36: virtual gfx::NativeWindow
GetNativeWindow();
On 2012/12/19 23:22:38, sky wrote:
> why isn't this pure virtual, in fact I would tend to make all of these pure
> virtual.

I don't see a reason not to make these pure virtual.  I've addressed this in the
second CL.

[Mike Wittman, 2012-12-21 19:50:28]

On 2012/12/21 01:55:14, Mike Wittman wrote:
>
https://codereview.chromium.org/11647017/diff/1/chrome/browser/ui/web_content...
> File chrome/browser/ui/web_contents_modal_dialog.h (right):
> 
>
https://codereview.chromium.org/11647017/diff/1/chrome/browser/ui/web_content...
> chrome/browser/ui/web_contents_modal_dialog.h:17: class WebContentsModalDialog
{
> On 2012/12/19 23:22:38, sky wrote:
> > I believe this is going to lose history. Any chance you could rename the
class
> > first, then the methods so that we preserve history? Maybe you can get it to
> > work with playing with --similarity or whatever it is.
> 
> It was easier for me to do the reverse given the order in which I made the
> original changes.  I've peeled off the file and class renames in patch set 2,
> and created a second CL with those changes at
> https://codereview.chromium.org/11633052.
> 
>
https://codereview.chromium.org/11647017/diff/1/chrome/browser/ui/web_content...
> chrome/browser/ui/web_contents_modal_dialog.h:36: virtual gfx::NativeWindow
> GetNativeWindow();
> On 2012/12/19 23:22:38, sky wrote:
> > why isn't this pure virtual, in fact I would tend to make all of these pure
> > virtual.
> 
> I don't see a reason not to make these pure virtual.  I've addressed this in
the
> second CL.

Friendly ping... does this CL look OK as well?  Just want to make sure this
doesn't fall through the cracks.

[sky, 2012-12-21 20:36:13]

Sorry, didn't realize it was updated. LGTM

[sky, 2012-12-21 20:36:26]

And thanks for separating into 2 patches!

[commit-bot: I haz the power, 2012-12-21 21:00:04]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/wittman@chromium.org/11647017/4001

[commit-bot: I haz the power, 2012-12-21 23:08:50]

Retried try job too often on linux_chromeos for step(s) browser_tests

[commit-bot: I haz the power, 2012-12-21 23:10:07]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/wittman@chromium.org/11647017/4001

[commit-bot: I haz the power, 2012-12-22 01:01:03]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/wittman@chromium.org/11647017/4001

[commit-bot: I haz the power, 2012-12-22 04:42:46]

Retried try job too often on win_rel for step(s) browser_tests

[commit-bot: I haz the power, 2012-12-22 05:50:24]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/wittman@chromium.org/11647017/4001

[commit-bot: I haz the power, 2012-12-22 10:18:49]

Change committed as 174517