chrome/browser/ui/browser_commands.cc - Issue 11647017: Rename platform-independent ConstrainedWindow types to WebContentsModalDialog types (part 1)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/browser_commands.cc

Issue 11647017: Rename platform-independent ConstrainedWindow types to WebContentsModalDialog types (part 1) (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: stage changes to preserve history Created 8 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/browser_commands.cc

diff --git a/chrome/browser/ui/browser_commands.cc b/chrome/browser/ui/browser_commands.cc

index f91ef9cd87c437cd52e91d2a3ffcd7f64ad9762d..48ac2ba2c446fbe46b06899084db8c281ab83429 100644

--- a/chrome/browser/ui/browser_commands.cc

+++ b/chrome/browser/ui/browser_commands.cc

@@ -180,7 +180,7 @@ bool HasConstrainedWindow(const Browser* browser) {

ConstrainedWindowTabHelper* constrained_window_tab_helper =

ConstrainedWindowTabHelper::FromWebContents(web_contents);

- return constrained_window_tab_helper->constrained_window_count() > 0;

+ return constrained_window_tab_helper->dialog_count() > 0;

}

bool PrintPreviewShowing(const Browser* browser) {

« no previous file with comments | « chrome/browser/ui/browser.cc ('k') | chrome/browser/ui/cocoa/browser_window_controller.mm » ('j') | no next file with comments »