chrome/browser/ui/cocoa/extensions/extension_install_dialog_controller.mm - Issue 11647017: Rename platform-independent ConstrainedWindow types to WebContentsModalDialog types (part 1)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/extensions/extension_install_dialog_controller.mm

Issue 11647017: Rename platform-independent ConstrainedWindow types to WebContentsModalDialog types (part 1) (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: stage changes to preserve history Created 8 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/cocoa/content_settings/collected_cookies_mac_browsertest.mm ('k') | chrome/browser/ui/cocoa/extensions/media_galleries_dialog_cocoa.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/extensions/extension_install_dialog_controller.mm

diff --git a/chrome/browser/ui/cocoa/extensions/extension_install_dialog_controller.mm b/chrome/browser/ui/cocoa/extensions/extension_install_dialog_controller.mm

index 99bef89000c9e9ee0998186a3a6773d2e79dc303..df1839331c5731e878b081de2b460f8b3c556dcb 100644

--- a/chrome/browser/ui/cocoa/extensions/extension_install_dialog_controller.mm

+++ b/chrome/browser/ui/cocoa/extensions/extension_install_dialog_controller.mm

@@ -54,13 +54,13 @@ ExtensionInstallDialogController::~ExtensionInstallDialogController() {

void ExtensionInstallDialogController::InstallUIProceed() {

delegate_->InstallUIProceed();

delegate_ = NULL;

- constrained_window_->CloseConstrainedWindow();

+ constrained_window_->CloseWebContentsModalDialog();

}

void ExtensionInstallDialogController::InstallUIAbort(bool user_initiated) {

delegate_->InstallUIAbort(user_initiated);

delegate_ = NULL;

- constrained_window_->CloseConstrainedWindow();

+ constrained_window_->CloseWebContentsModalDialog();

}

void ExtensionInstallDialogController::OnConstrainedWindowClosed(