chrome/browser/ui/cocoa/constrained_window/constrained_window_mac_browsertest.mm - Issue 11647017: Rename platform-independent ConstrainedWindow types to WebContentsModalDialog types (part 1)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/constrained_window/constrained_window_mac_browsertest.mm

Issue 11647017: Rename platform-independent ConstrainedWindow types to WebContentsModalDialog types (part 1) (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: stage changes to preserve history Created 8 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/cocoa/constrained_window/constrained_window_mac.mm ('k') | chrome/browser/ui/cocoa/content_settings/collected_cookies_mac.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/constrained_window/constrained_window_mac_browsertest.mm

diff --git a/chrome/browser/ui/cocoa/constrained_window/constrained_window_mac_browsertest.mm b/chrome/browser/ui/cocoa/constrained_window/constrained_window_mac_browsertest.mm

index 4fdfb2c312a87ff00a963bf32cbce280c88aad88..77b413eddf4afed0069f969fac46a9f64c0a72a0 100644

--- a/chrome/browser/ui/cocoa/constrained_window/constrained_window_mac_browsertest.mm

+++ b/chrome/browser/ui/cocoa/constrained_window/constrained_window_mac_browsertest.mm

@@ -85,7 +85,7 @@ IN_PROC_BROWSER_TEST_F(ConstrainedWindowMacTest, ShowInInactiveTab) {

browser()->tab_strip_model()->ActivateTabAt(0, true);

EXPECT_EQ(1.0, [sheet_window_ alphaValue]);

- dialog.CloseConstrainedWindow();

+ dialog.CloseWebContentsModalDialog();

}

// If a tab has never been shown then the associated tab view for the web

@@ -113,7 +113,7 @@ IN_PROC_BROWSER_TEST_F(ConstrainedWindowMacTest, ShowInUninitializedTab) {

EXPECT_TRUE([sheet_window_ isVisible]);

EXPECT_EQ(1.0, [sheet_window_ alphaValue]);

- dialog.CloseConstrainedWindow();

+ dialog.CloseWebContentsModalDialog();

}

// Test that adding a sheet disables tab dragging.

@@ -125,7 +125,7 @@ IN_PROC_BROWSER_TEST_F(ConstrainedWindowMacTest, TabDragging) {

EXPECT_TRUE([controller_ isTabDraggable:tab_view0_]);

EXPECT_FALSE([controller_ isTabDraggable:tab_view1_]);

- dialog.CloseConstrainedWindow();

+ dialog.CloseWebContentsModalDialog();

}

// Test that closing a browser window with a sheet works.

@@ -165,5 +165,5 @@ IN_PROC_BROWSER_TEST_F(ConstrainedWindowMacTest, Fullscreen) {

EXPECT_FALSE(chrome::IsCommandEnabled(browser(), IDC_FULLSCREEN));

- dialog.CloseConstrainedWindow();

+ dialog.CloseWebContentsModalDialog();

}