Rename platform-independent ConstrainedWindow types to WebContentsModalDialog types (part 1)

chrome/browser/ui/web_contents_modal_dialog.h

+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_UI_WEB_CONTENTS_MODAL_DIALOG_H_
+#define CHROME_BROWSER_UI_WEB_CONTENTS_MODAL_DIALOG_H_
+
+#include "build/build_config.h"
+#include "ui/gfx/native_widget_types.h"
+
+///////////////////////////////////////////////////////////////////////////////
+// WebContentsModalDialog
+//
+//  This interface represents a window that is constrained to a
+//  WebContentsView's bounds.
+//
+class WebContentsModalDialog {

[sky, 2012/12/19 23:22:38]

I believe this is going to lose history. Any chance you could rename the class
first, then the methods so that we preserve history? Maybe you can get it to
work with playing with --similarity or whatever it is.

[Mike Wittman, 2012/12/21 01:55:16]

It was easier for me to do the reverse given the order in which I made the
original changes.  I've peeled off the file and class renames in patch set 2,
and created a second CL with those changes at
https://codereview.chromium.org/11633052.

+ public:
+  // Makes the web contents modal dialog visible. Only one web contents modal
+  // dialog is shown at a time per tab.
+  virtual void ShowWebContentsModalDialog() = 0;
+
+  // Closes the web contents modal dialog.
+  virtual void CloseWebContentsModalDialog() = 0;
+
+  // Sets focus on the web contents modal dialog.
+  virtual void FocusWebContentsModalDialog();
+
+  // Runs a pulse animation for the web contents modal dialog.
+  virtual void PulseWebContentsModalDialog();
+
+  // Checks if the web contents modal dialog can be shown.
+  virtual bool CanShowWebContentsModalDialog();
+
+  // Returns the native window of the web contents modal dialog.
+  virtual gfx::NativeWindow GetNativeWindow();

[sky, 2012/12/19 23:22:38]

why isn't this pure virtual, in fact I would tend to make all of these pure
virtual.

[Mike Wittman, 2012/12/21 01:55:16]

I don't see a reason not to make these pure virtual.  I've addressed this in the
second CL.

+
+ protected:
+  virtual ~WebContentsModalDialog() {}
+};
+
+#endif  // CHROME_BROWSER_UI_WEB_CONTENTS_MODAL_DIALOG_H_