Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(238)

Issue 1164373003: Revert of change SkDraw and all Blitters to use pixmap instead of bitmap (Closed)

Created:
5 years, 6 months ago by reed2
Modified:
5 years, 6 months ago
Reviewers:
jvanverth1, scroggo, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of change SkDraw and all Blitters to use pixmap instead of bitmap (patchset #6 id:100001 of https://codereview.chromium.org/1148793007/) Reason for revert: speculative revert to try to unblock DEPS roll Original issue's description: > change SkDraw and all Blitters to use pixmap instead of bitmap > > BUG=skia: > > Committed: https://skia.googlesource.com/skia/+/c31af44336f5eb4a50e83e76e51962d46c3ed458 TBR=scroggo@google.com,jvanverth@google.com,reed@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/b3f0ec9f9967da2f80f0d842cb7fd53617b48de3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+381 lines, -312 lines) Patch
M bench/CoverageBench.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M gm/fatpathfill.cpp View 3 chunks +14 lines, -9 lines 0 comments Download
M include/core/SkDraw.h View 1 chunk +1 line, -2 lines 0 comments Download
M src/core/SkAAClip.h View 1 chunk +3 lines, -2 lines 0 comments Download
M src/core/SkAAClip.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/core/SkBlitBWMaskTemplate.h View 2 chunks +5 lines, -5 lines 0 comments Download
M src/core/SkBlitMask.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/core/SkBlitMask_D32.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M src/core/SkBlitter.h View 6 chunks +6 lines, -6 lines 0 comments Download
M src/core/SkBlitter.cpp View 6 chunks +6 lines, -6 lines 0 comments Download
M src/core/SkBlitter_A8.cpp View 19 chunks +22 lines, -22 lines 0 comments Download
M src/core/SkBlitter_ARGB32.cpp View 20 chunks +29 lines, -29 lines 0 comments Download
M src/core/SkBlitter_RGB16.cpp View 35 chunks +53 lines, -49 lines 0 comments Download
M src/core/SkCanvas.cpp View 1 chunk +1 line, -3 lines 0 comments Download
M src/core/SkCoreBlitters.h View 9 chunks +14 lines, -14 lines 0 comments Download
M src/core/SkDeviceLooper.h View 3 chunks +8 lines, -7 lines 0 comments Download
M src/core/SkDeviceLooper.cpp View 5 chunks +18 lines, -13 lines 0 comments Download
M src/core/SkDraw.cpp View 26 chunks +61 lines, -47 lines 0 comments Download
M src/core/SkScalerContext.cpp View 4 chunks +11 lines, -11 lines 0 comments Download
M src/core/SkScan_Path.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/effects/SkLayerRasterizer.cpp View 2 chunks +5 lines, -5 lines 0 comments Download
M src/gpu/GrAADistanceFieldPathRenderer.cpp View 3 chunks +14 lines, -8 lines 0 comments Download
M src/gpu/GrSWMaskHelper.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/gpu/GrSWMaskHelper.cpp View 6 chunks +25 lines, -21 lines 0 comments Download
M src/utils/SkTextureCompressor.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/utils/SkTextureCompressor.cpp View 1 chunk +7 lines, -5 lines 0 comments Download
M src/utils/SkTextureCompressor_Blitter.h View 1 chunk +1 line, -1 line 0 comments Download
M tests/DeviceLooperTest.cpp View 5 chunks +12 lines, -11 lines 0 comments Download
M tests/TextureCompressionTest.cpp View 12 chunks +51 lines, -22 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
reed2
Created Revert of change SkDraw and all Blitters to use pixmap instead of bitmap
5 years, 6 months ago (2015-06-09 02:57:36 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1164373003/1
5 years, 6 months ago (2015-06-09 02:57:53 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/b3f0ec9f9967da2f80f0d842cb7fd53617b48de3
5 years, 6 months ago (2015-06-09 02:58:11 UTC) #3
reed2
5 years, 6 months ago (2015-06-09 04:44:43 UTC) #4
Message was sent while issue was closed.
sample failure
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...

Powered by Google App Engine
This is Rietveld 408576698