Source/modules/credentialmanager/PasswordCredential.idl - Issue 1162443006: Credential Management: Rename 'LocalCredential' to 'PasswordCredential' (1/3)

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: Source/modules/credentialmanager/PasswordCredential.idl

Issue 1162443006: Credential Management: Rename 'LocalCredential' to 'PasswordCredential' (1/3) (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@add-type

Patch Set: Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« Source/modules/credentialmanager/PasswordCredential.h ('K') | « Source/modules/credentialmanager/PasswordCredential.cpp ('k') | Source/modules/modules.gypi » ('j') | Source/platform/credentialmanager/PlatformPasswordCredential.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2014 The Chromium Authors. All rights reserved.	1 // Copyright 2014 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 [	5 [

6 RuntimeEnabled=CredentialManager,	6 RuntimeEnabled=CredentialManager,

7 RaisesException=Constructor,	7 RaisesException=Constructor,

8 Constructor(DOMString id, DOMString password, optional DOMString name, optio nal DOMString avatarURL)	8 Constructor(DOMString id, DOMString password, optional DOMString name, optio nal DOMString avatarURL)

9 ] interface LocalCredential : Credential {	9 ] interface PasswordCredential : Credential {
	vabr (Chromium) 2015/06/01 09:10:13 Just to double-check -- as you pointed out in the Just to double-check -- as you pointed out in the description, this does not update the interface, so making the parent a LocallyStoredCredential to match https://w3c.github.io/webappsec/specs/credentialmanagement/#interfaces-creden... will be done in Patch 3 or later, correct? Mike West 2015/06/01 09:12:03 That will be done in patch #17. It will introduce Show quoted text On 2015/06/01 at 09:10:13, vabr (Chromium) wrote: > Just to double-check -- as you pointed out in the description, this does not update the interface, so making the parent a LocallyStoredCredential to match https://w3c.github.io/webappsec/specs/credentialmanagement/#interfaces-creden... will be done in Patch 3 or later, correct? That will be done in patch #17. It will introduce a lot of churn, so I'm avoiding it.
10 readonly attribute DOMString password;	10 readonly attribute DOMString password;

11 readonly attribute FormData formData;	11 readonly attribute FormData formData;

12 };	12 };

OLD	NEW