Source/platform/exported/WebCredential.cpp - Issue 1162443006: Credential Management: Rename 'LocalCredential' to 'PasswordCredential' (1/3)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/platform/exported/WebCredential.cpp

Issue 1162443006: Credential Management: Rename 'LocalCredential' to 'PasswordCredential' (1/3) (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@add-type

Patch Set: Test. Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/platform/credentialmanager/PlatformPasswordCredential.cpp ('k') | Source/platform/exported/WebLocalCredential.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/platform/exported/WebCredential.cpp

diff --git a/Source/platform/exported/WebCredential.cpp b/Source/platform/exported/WebCredential.cpp

index d4e678e30dd24fc7bdaf851e825e03c18b2cfb90..2289b751005024a21fbfdd97bfaa5228fa4fd707 100644

--- a/Source/platform/exported/WebCredential.cpp

+++ b/Source/platform/exported/WebCredential.cpp

@@ -7,15 +7,15 @@

#include "platform/credentialmanager/PlatformCredential.h"

#include "public/platform/WebFederatedCredential.h"

-#include "public/platform/WebLocalCredential.h"

+#include "public/platform/WebPasswordCredential.h"

namespace blink {

WebCredential WebCredential::create(PlatformCredential* credential)

{

- if (credential->isLocal()) {

- WebLocalCredential local(credential);

- return local;

+ if (credential->isPassword()) {

+ WebPasswordCredential password(credential);

+ return password;

}

if (credential->isFederated()) {

@@ -78,9 +78,9 @@ WebString WebCredential::type() const

return m_platformCredential->type();

}

-bool WebCredential::isLocalCredential() const

+bool WebCredential::isPasswordCredential() const

{

- return m_platformCredential->isLocal();

+ return m_platformCredential->isPassword();

}

bool WebCredential::isFederatedCredential() const