Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(218)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 116213006: Update libwebp to 0.4.0 (Closed)

Created:
6 years, 11 months ago by urvang (Google)
Modified:
6 years, 11 months ago
Reviewers:
fbarchard
CC:
chromium-reviews
Visibility:
Public.

Description

Update libwebp to 0.4.0 Note: This reverts the changes to .h and .c files done in http://crrev.com/95873002. However, this should still work for non-NEON builds as NEON specific functions are built as empty functions in that case. BUG=331619 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=244226

Patch Set 1 : #

Total comments: 2

Patch Set 2 : After Blink Roll #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4354 lines, -2724 lines) Patch
M third_party/libwebp/README.chromium View 2 chunks +3 lines, -12 lines 0 comments Download
M third_party/libwebp/dec/alpha.c View 1 chunk +96 lines, -50 lines 0 comments Download
A third_party/libwebp/dec/alphai.h View 1 chunk +55 lines, -0 lines 0 comments Download
M third_party/libwebp/dec/buffer.c View 2 chunks +0 lines, -7 lines 0 comments Download
M third_party/libwebp/dec/decode_vp8.h View 3 chunks +4 lines, -3 lines 0 comments Download
M third_party/libwebp/dec/frame.c View 22 chunks +321 lines, -197 lines 0 comments Download
M third_party/libwebp/dec/idec.c View 18 chunks +47 lines, -42 lines 0 comments Download
M third_party/libwebp/dec/io.c View 4 chunks +2 lines, -9 lines 0 comments Download
M third_party/libwebp/dec/layer.c View 2 chunks +0 lines, -7 lines 0 comments Download
M third_party/libwebp/dec/quant.c View 2 chunks +2 lines, -7 lines 0 comments Download
M third_party/libwebp/dec/tree.c View 8 chunks +22 lines, -119 lines 0 comments Download
M third_party/libwebp/dec/vp8.c View 12 chunks +114 lines, -185 lines 0 comments Download
M third_party/libwebp/dec/vp8i.h View 12 chunks +84 lines, -61 lines 0 comments Download
M third_party/libwebp/dec/vp8l.c View 24 chunks +359 lines, -229 lines 0 comments Download
M third_party/libwebp/dec/vp8li.h View 5 chunks +22 lines, -9 lines 0 comments Download
M third_party/libwebp/dec/webp.c View 14 chunks +21 lines, -19 lines 0 comments Download
M third_party/libwebp/dec/webpi.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/libwebp/demux/demux.c View 23 chunks +85 lines, -71 lines 0 comments Download
M third_party/libwebp/dsp/cpu.c View 2 chunks +0 lines, -7 lines 0 comments Download
M third_party/libwebp/dsp/dec.c View 7 chunks +24 lines, -9 lines 0 comments Download
M third_party/libwebp/dsp/dec_neon.c View 9 chunks +72 lines, -46 lines 0 comments Download
M third_party/libwebp/dsp/dec_sse2.c View 5 chunks +69 lines, -23 lines 0 comments Download
M third_party/libwebp/dsp/dsp.h View 6 chunks +12 lines, -8 lines 0 comments Download
M third_party/libwebp/dsp/enc.c View 6 chunks +30 lines, -10 lines 0 comments Download
M third_party/libwebp/dsp/enc_neon.c View 3 chunks +1 line, -8 lines 0 comments Download
M third_party/libwebp/dsp/enc_sse2.c View 9 chunks +26 lines, -38 lines 0 comments Download
M third_party/libwebp/dsp/lossless.h View 5 chunks +123 lines, -7 lines 0 comments Download
M third_party/libwebp/dsp/lossless.c View 10 chunks +248 lines, -103 lines 0 comments Download
M third_party/libwebp/dsp/upsampling.c View 7 chunks +10 lines, -13 lines 0 comments Download
M third_party/libwebp/dsp/upsampling_neon.c View 7 chunks +70 lines, -99 lines 0 comments Download
M third_party/libwebp/dsp/upsampling_sse2.c View 7 chunks +55 lines, -54 lines 0 comments Download
M third_party/libwebp/dsp/yuv.h View 8 chunks +147 lines, -114 lines 0 comments Download
M third_party/libwebp/dsp/yuv.c View 3 chunks +144 lines, -12 lines 0 comments Download
M third_party/libwebp/enc/alpha.c View 10 chunks +113 lines, -111 lines 0 comments Download
M third_party/libwebp/enc/analysis.c View 6 chunks +102 lines, -26 lines 0 comments Download
M third_party/libwebp/enc/backward_references.h View 3 chunks +2 lines, -69 lines 0 comments Download
M third_party/libwebp/enc/backward_references.c View 13 chunks +41 lines, -41 lines 0 comments Download
M third_party/libwebp/enc/config.c View 6 chunks +6 lines, -9 lines 0 comments Download
M third_party/libwebp/enc/cost.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/libwebp/enc/cost.c View 2 chunks +100 lines, -107 lines 0 comments Download
M third_party/libwebp/enc/filter.c View 3 chunks +92 lines, -32 lines 0 comments Download
M third_party/libwebp/enc/frame.c View 10 chunks +216 lines, -127 lines 0 comments Download
M third_party/libwebp/enc/histogram.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/libwebp/enc/histogram.c View 1 chunk +3 lines, -5 lines 0 comments Download
M third_party/libwebp/enc/iterator.c View 7 chunks +116 lines, -84 lines 0 comments Download
M third_party/libwebp/enc/layer.c View 2 chunks +0 lines, -7 lines 0 comments Download
M third_party/libwebp/enc/picture.c View 22 chunks +249 lines, -40 lines 0 comments Download
M third_party/libwebp/enc/quant.c View 26 chunks +188 lines, -84 lines 0 comments Download
M third_party/libwebp/enc/syntax.c View 2 chunks +0 lines, -7 lines 0 comments Download
M third_party/libwebp/enc/token.c View 3 chunks +24 lines, -7 lines 0 comments Download
M third_party/libwebp/enc/tree.c View 4 chunks +3 lines, -11 lines 0 comments Download
M third_party/libwebp/enc/vp8enci.h View 9 chunks +51 lines, -31 lines 0 comments Download
M third_party/libwebp/enc/vp8l.c View 8 chunks +8 lines, -15 lines 0 comments Download
M third_party/libwebp/enc/vp8li.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/libwebp/enc/webpenc.c View 10 chunks +21 lines, -37 lines 0 comments Download
M third_party/libwebp/libwebp.gyp View 2 chunks +2 lines, -0 lines 0 comments Download
A third_party/libwebp/utils/alpha_processing.h View 1 chunk +46 lines, -0 lines 0 comments Download
A third_party/libwebp/utils/alpha_processing.c View 1 chunk +196 lines, -0 lines 0 comments Download
M third_party/libwebp/utils/bit_reader.h View 7 chunks +15 lines, -12 lines 0 comments Download
M third_party/libwebp/utils/bit_reader.c View 2 chunks +0 lines, -7 lines 0 comments Download
M third_party/libwebp/utils/bit_writer.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/libwebp/utils/bit_writer.c View 4 chunks +5 lines, -9 lines 0 comments Download
M third_party/libwebp/utils/color_cache.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/libwebp/utils/color_cache.c View 2 chunks +0 lines, -7 lines 0 comments Download
M third_party/libwebp/utils/filters.h View 3 chunks +7 lines, -5 lines 0 comments Download
M third_party/libwebp/utils/filters.c View 9 chunks +91 lines, -55 lines 0 comments Download
M third_party/libwebp/utils/huffman.h View 3 chunks +12 lines, -5 lines 0 comments Download
M third_party/libwebp/utils/huffman.c View 5 chunks +56 lines, -8 lines 0 comments Download
M third_party/libwebp/utils/huffman_encode.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/libwebp/utils/huffman_encode.c View 1 chunk +1 line, -1 line 0 comments Download
M third_party/libwebp/utils/quant_levels.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/libwebp/utils/quant_levels.c View 2 chunks +0 lines, -7 lines 0 comments Download
M third_party/libwebp/utils/quant_levels_dec.h View 1 chunk +7 lines, -5 lines 0 comments Download
M third_party/libwebp/utils/quant_levels_dec.c View 1 chunk +6 lines, -12 lines 0 comments Download
A third_party/libwebp/utils/random.h View 1 chunk +62 lines, -0 lines 0 comments Download
A third_party/libwebp/utils/random.c View 1 chunk +43 lines, -0 lines 0 comments Download
M third_party/libwebp/utils/rescaler.h View 4 chunks +11 lines, -5 lines 0 comments Download
M third_party/libwebp/utils/rescaler.c View 3 chunks +5 lines, -7 lines 0 comments Download
M third_party/libwebp/utils/thread.h View 3 chunks +9 lines, -4 lines 0 comments Download
M third_party/libwebp/utils/thread.c View 9 chunks +18 lines, -22 lines 0 comments Download
M third_party/libwebp/utils/utils.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/libwebp/utils/utils.c View 2 chunks +0 lines, -7 lines 0 comments Download
M third_party/libwebp/webp/decode.h View 4 chunks +6 lines, -5 lines 0 comments Download
M third_party/libwebp/webp/demux.h View 5 chunks +46 lines, -38 lines 0 comments Download
M third_party/libwebp/webp/encode.h View 5 chunks +17 lines, -4 lines 0 comments Download
M third_party/libwebp/webp/mux.h View 15 chunks +70 lines, -51 lines 0 comments Download
M third_party/libwebp/webp/mux_types.h View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
urvang (Google)
6 years, 11 months ago (2014-01-07 03:30:00 UTC) #1
fbarchard
https://codereview.chromium.org/116213006/diff/740001/third_party/libwebp/README.chromium File third_party/libwebp/README.chromium (right): https://codereview.chromium.org/116213006/diff/740001/third_party/libwebp/README.chromium#newcode24 third_party/libwebp/README.chromium:24: Revert patch f7fc4bc: dec/webp.c: don't wait for data before ...
6 years, 11 months ago (2014-01-07 03:50:04 UTC) #2
urvang (Google)
https://codereview.chromium.org/116213006/diff/740001/third_party/libwebp/README.chromium File third_party/libwebp/README.chromium (right): https://codereview.chromium.org/116213006/diff/740001/third_party/libwebp/README.chromium#newcode24 third_party/libwebp/README.chromium:24: Revert patch f7fc4bc: dec/webp.c: don't wait for data before ...
6 years, 11 months ago (2014-01-07 03:58:17 UTC) #3
fbarchard
lgtm
6 years, 11 months ago (2014-01-07 04:12:21 UTC) #4
urvang (Google)
Note: Trybots will succeed after the Blink roll happens. Meanwhile, tested OK on Linux locally.
6 years, 11 months ago (2014-01-07 04:13:46 UTC) #5
Mostyn Bramley-Moore
Since this touches neon code, don't forget android try jobs.
6 years, 11 months ago (2014-01-07 23:02:08 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/urvang@google.com/116213006/900001
6 years, 11 months ago (2014-01-10 10:23:35 UTC) #7
commit-bot: I haz the power
Retried try job too often on linux_rel for step(s) check_deps2git http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&number=212610
6 years, 11 months ago (2014-01-10 11:17:17 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/urvang@google.com/116213006/900001
6 years, 11 months ago (2014-01-10 19:36:54 UTC) #9
commit-bot: I haz the power
6 years, 11 months ago (2014-01-10 20:08:08 UTC) #10
Message was sent while issue was closed. 
Change committed as 244226

Powered by Google App Engine
This is Rietveld 408576698