Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1161063003: Revert "Revert of Move copy-surface-as-draw fallback to GrGLGpu. (patchset #12 id:220001 of https:/… (Closed)

Created:
5 years, 6 months ago by bsalomon
Modified:
5 years, 6 months ago
Reviewers:
joshualitt
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert "Revert of Move copy-surface-as-draw fallback to GrGLGpu. (patchset #12 id:220001 of https://codereview.chromium.org/1144433002/)" This reverts commit 404b3b264b833eb7cffdc833c7e2ebbd708e123a. Committed: https://skia.googlesource.com/skia/+/6df86409ca586c3cb34f616f03501bd96181f9e4

Patch Set 1 #

Patch Set 2 : update #

Unified diffs Side-by-side diffs Delta from patch set Stats (+456 lines, -286 lines) Patch
M src/gpu/GrDrawTarget.h View 1 chunk +3 lines, -13 lines 0 comments Download
M src/gpu/GrDrawTarget.cpp View 3 chunks +7 lines, -56 lines 0 comments Download
M src/gpu/GrGpu.h View 1 chunk +0 lines, -10 lines 0 comments Download
M src/gpu/GrImmediateDrawTarget.h View 1 chunk +0 lines, -4 lines 0 comments Download
M src/gpu/GrImmediateDrawTarget.cpp View 1 chunk +0 lines, -8 lines 0 comments Download
M src/gpu/GrInOrderDrawBuffer.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M src/gpu/GrTest.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M src/gpu/gl/GrGLCaps.h View 1 4 chunks +9 lines, -1 line 0 comments Download
M src/gpu/gl/GrGLCaps.cpp View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/gpu/gl/GrGLGpu.h View 6 chunks +35 lines, -7 lines 0 comments Download
M src/gpu/gl/GrGLGpu.cpp View 10 chunks +342 lines, -129 lines 0 comments Download
M src/gpu/gl/GrGLGpuProgramCache.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/gpu/gl/GrGLSL.h View 1 chunk +18 lines, -0 lines 0 comments Download
M src/gpu/gl/GrGLSL.cpp View 1 chunk +19 lines, -0 lines 0 comments Download
M src/gpu/gl/GrGLVertexArray.h View 2 chunks +4 lines, -4 lines 0 comments Download
M src/gpu/gl/GrGLVertexArray.cpp View 4 chunks +11 lines, -12 lines 0 comments Download
M src/gpu/gl/builders/GrGLFragmentShaderBuilder.cpp View 2 chunks +3 lines, -23 lines 0 comments Download
M src/gpu/gl/builders/GrGLProgramBuilder.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M src/gpu/gl/builders/GrGLShaderBuilder.cpp View 2 chunks +1 line, -9 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
bsalomon
5 years, 6 months ago (2015-06-01 17:18:14 UTC) #2
joshualitt
On 2015/06/01 17:18:14, bsalomon wrote: lgtm
5 years, 6 months ago (2015-06-01 17:20:36 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1161063003/20001
5 years, 6 months ago (2015-06-01 17:27:23 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://skia.googlesource.com/skia/+/6df86409ca586c3cb34f616f03501bd96181f9e4
5 years, 6 months ago (2015-06-01 17:41:54 UTC) #6
darktears
On 2015/06/01 at 17:41:54, commit-bot wrote: > Committed patchset #2 (id:20001) as https://skia.googlesource.com/skia/+/6df86409ca586c3cb34f616f03501bd96181f9e4 Any plan ...
5 years, 6 months ago (2015-06-16 16:28:10 UTC) #7
bsalomon
5 years, 6 months ago (2015-06-16 16:49:23 UTC) #8
Message was sent while issue was closed. 
On 2015/06/16 16:28:10, darktears wrote:
> On 2015/06/01 at 17:41:54, commit-bot wrote:
> > Committed patchset #2 (id:20001) as
> https://skia.googlesource.com/skia/+/6df86409ca586c3cb34f616f03501bd96181f9e4
> 
> Any plan to backport this prior to M45?

I was not planning to back port it. I'd need an approved release blocker to get
it into 44 at this point.

Powered by Google App Engine
This is Rietveld 408576698