Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(437)

Issue 1160983004: [turbofan] First step towards sanitizing for-in and making it optimizable. (Closed)

Created:
5 years, 6 months ago by Benedikt Meurer
Modified:
5 years, 6 months ago
CC:
v8-dev, v8-mips-ports_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] First step towards sanitizing for-in and making it optimizable. In a nutshell: The FILTER_KEY builtin is gone, and was replaced by a simple runtime call to ForInFilter, which does everything and is even cheaper (because FILTER_KEY used to call into the runtime anyway). And ForInFilter returns either the name or undefined, which makes it possible to remove the control flow construction from the AstGraphBuilder, and thereby make both the initialization and the per-loop code of for-in optimizable later (in typed lowering). R=jarin@chromium.org Committed: https://crrev.com/e2e47f30be06e6ea6b8a3cc90138381914ecd07d Cr-Commit-Position: refs/heads/master@{#28711}

Patch Set 1 #

Patch Set 2 : REBASE. Refactoring. MIPS ports. #

Patch Set 3 : Add some comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+478 lines, -275 lines) Patch
M BUILD.gn View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/arm/full-codegen-arm.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M src/arm64/full-codegen-arm64.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M src/builtins.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/compiler/ast-graph-builder.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
M src/compiler/ast-graph-builder.cc View 1 2 chunks +72 lines, -133 lines 0 comments Download
M src/compiler/control-builders.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
M src/compiler/control-builders.cc View 1 1 chunk +10 lines, -0 lines 0 comments Download
M src/compiler/js-generic-lowering.cc View 1 2 1 chunk +202 lines, -0 lines 0 comments Download
M src/compiler/js-operator.h View 1 chunk +5 lines, -0 lines 0 comments Download
M src/compiler/js-operator.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M src/compiler/linkage.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M src/compiler/opcodes.h View 1 chunk +4 lines, -0 lines 0 comments Download
M src/compiler/operator-properties.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M src/compiler/typer.cc View 1 chunk +24 lines, -0 lines 0 comments Download
M src/compiler/verifier.cc View 1 1 chunk +19 lines, -0 lines 0 comments Download
M src/hydrogen.cc View 1 chunk +8 lines, -3 lines 0 comments Download
M src/ia32/full-codegen-ia32.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/mips/full-codegen-mips.cc View 1 1 chunk +3 lines, -2 lines 0 comments Download
M src/mips64/full-codegen-mips64.cc View 1 1 chunk +3 lines, -2 lines 0 comments Download
M src/runtime.js View 2 chunks +0 lines, -11 lines 0 comments Download
M src/runtime/runtime.h View 1 4 chunks +33 lines, -28 lines 0 comments Download
M src/runtime/runtime-array.cc View 1 1 chunk +0 lines, -81 lines 0 comments Download
A src/runtime/runtime-forin.cc View 1 1 chunk +67 lines, -0 lines 0 comments Download
M src/runtime/runtime-utils.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/x64/full-codegen-x64.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/gyp/v8.gyp View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 12 (3 generated)
Benedikt Meurer
5 years, 6 months ago (2015-05-29 11:54:35 UTC) #1
Benedikt Meurer
Michi, Jaro: Please take a look and comment on the direction. Paul: Please add MIPS ...
5 years, 6 months ago (2015-05-29 11:55:26 UTC) #3
paul.l...
I'm OOO today, but have cc'd the mips team. You should have it later this ...
5 years, 6 months ago (2015-06-01 05:45:30 UTC) #5
Benedikt Meurer
On 2015/06/01 05:45:30, paul.l... wrote: > I'm OOO today, but have cc'd the mips team. ...
5 years, 6 months ago (2015-06-01 06:10:39 UTC) #6
Benedikt Meurer
Hey Jaro, This is the unoptimized, optimizable, and fixed version of for-in. The next step ...
5 years, 6 months ago (2015-06-01 06:16:35 UTC) #7
Jarin
lgtm
5 years, 6 months ago (2015-06-01 07:16:49 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1160983004/40001
5 years, 6 months ago (2015-06-01 07:19:21 UTC) #10
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 6 months ago (2015-06-01 07:20:55 UTC) #11
commit-bot: I haz the power
5 years, 6 months ago (2015-06-01 07:21:11 UTC) #12
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/e2e47f30be06e6ea6b8a3cc90138381914ecd07d
Cr-Commit-Position: refs/heads/master@{#28711}

Powered by Google App Engine
This is Rietveld 408576698