src/compiler/linkage.cc - Issue 1160983004: [turbofan] First step towards sanitizing for-in and making it optimizable.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/compiler/linkage.cc

Issue 1160983004: [turbofan] First step towards sanitizing for-in and making it optimizable. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Add some comments. Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/compiler/linkage.cc

diff --git a/src/compiler/linkage.cc b/src/compiler/linkage.cc

index 881134f37081cf3c620802555716f231cee01faa..24f5e490a7391fa8f6e568dd69706dfc221bb431 100644

--- a/src/compiler/linkage.cc

+++ b/src/compiler/linkage.cc

@@ -114,9 +114,8 @@ bool Linkage::NeedsFrameState(Runtime::FunctionId function) {

case Runtime::kDefineClassMethod: // TODO(jarin): Is it safe?

case Runtime::kDefineGetterPropertyUnchecked: // TODO(jarin): Is it safe?

case Runtime::kDefineSetterPropertyUnchecked: // TODO(jarin): Is it safe?

- case Runtime::kForInCacheArrayLength:

- case Runtime::kForInInit:

- case Runtime::kForInNext:

+ case Runtime::kForInDone:

+ case Runtime::kForInStep:

case Runtime::kNewArguments:

case Runtime::kNewClosure:

case Runtime::kNewFunctionContext:

« no previous file with comments | « src/compiler/js-operator.cc ('k') | src/compiler/opcodes.h » ('j') | no next file with comments »