src/arm/full-codegen-arm.cc - Issue 1160983004: [turbofan] First step towards sanitizing for-in and making it optimizable.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/arm/full-codegen-arm.cc

Issue 1160983004: [turbofan] First step towards sanitizing for-in and making it optimizable. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Add some comments. Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/arm/full-codegen-arm.cc

diff --git a/src/arm/full-codegen-arm.cc b/src/arm/full-codegen-arm.cc

index 1446aeb392ed5806400b16ba8419cc7f9a9a72bb..7a0d9b658e96bee32369b65c588bbbc6366d2e1b 100644

--- a/src/arm/full-codegen-arm.cc

+++ b/src/arm/full-codegen-arm.cc

@@ -1271,9 +1271,11 @@ void FullCodeGenerator::VisitForInStatement(ForInStatement* stmt) {

// just skip it.

__ push(r1); // Enumerable.

__ push(r3); // Current entry.

- __ InvokeBuiltin(Builtins::FILTER_KEY, CALL_FUNCTION);

+ __ CallRuntime(Runtime::kForInFilter, 2);

PrepareForBailoutForId(stmt->FilterId(), TOS_REG);

- __ mov(r3, Operand(r0), SetCC);

+ __ mov(r3, Operand(r0));

+ __ LoadRoot(ip, Heap::kUndefinedValueRootIndex);

+ __ cmp(r0, ip);

__ b(eq, loop_statement.continue_label());

// Update the 'each' property or variable from the possibly filtered

« no previous file with comments | « BUILD.gn ('k') | src/arm64/full-codegen-arm64.cc » ('j') | no next file with comments »