Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Side by Side Diff: src/mips64/full-codegen-mips64.cc

Issue 1160983004: [turbofan] First step towards sanitizing for-in and making it optimizable. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Add some comments. Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/mips/full-codegen-mips.cc ('k') | src/runtime.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #if V8_TARGET_ARCH_MIPS64 7 #if V8_TARGET_ARCH_MIPS64
8 8
9 // Note on Mips implementation: 9 // Note on Mips implementation:
10 // 10 //
(...skipping 1238 matching lines...) Expand 10 before | Expand all | Expand 10 after
1249 1249
1250 // For proxies, no filtering is done. 1250 // For proxies, no filtering is done.
1251 // TODO(rossberg): What if only a prototype is a proxy? Not specified yet. 1251 // TODO(rossberg): What if only a prototype is a proxy? Not specified yet.
1252 DCHECK_EQ(static_cast<Smi*>(0), Smi::FromInt(0)); 1252 DCHECK_EQ(static_cast<Smi*>(0), Smi::FromInt(0));
1253 __ Branch(&update_each, eq, a2, Operand(zero_reg)); 1253 __ Branch(&update_each, eq, a2, Operand(zero_reg));
1254 1254
1255 // Convert the entry to a string or (smi) 0 if it isn't a property 1255 // Convert the entry to a string or (smi) 0 if it isn't a property
1256 // any more. If the property has been removed while iterating, we 1256 // any more. If the property has been removed while iterating, we
1257 // just skip it. 1257 // just skip it.
1258 __ Push(a1, a3); // Enumerable and current entry. 1258 __ Push(a1, a3); // Enumerable and current entry.
1259 __ InvokeBuiltin(Builtins::FILTER_KEY, CALL_FUNCTION); 1259 __ CallRuntime(Runtime::kForInFilter, 2);
1260 PrepareForBailoutForId(stmt->FilterId(), TOS_REG); 1260 PrepareForBailoutForId(stmt->FilterId(), TOS_REG);
1261 __ mov(a3, result_register()); 1261 __ mov(a3, result_register());
1262 __ Branch(loop_statement.continue_label(), eq, a3, Operand(zero_reg)); 1262 __ LoadRoot(at, Heap::kUndefinedValueRootIndex);
1263 __ Branch(loop_statement.continue_label(), eq, a3, Operand(at));
1263 1264
1264 // Update the 'each' property or variable from the possibly filtered 1265 // Update the 'each' property or variable from the possibly filtered
1265 // entry in register a3. 1266 // entry in register a3.
1266 __ bind(&update_each); 1267 __ bind(&update_each);
1267 __ mov(result_register(), a3); 1268 __ mov(result_register(), a3);
1268 // Perform the assignment as if via '='. 1269 // Perform the assignment as if via '='.
1269 { EffectContext context(this); 1270 { EffectContext context(this);
1270 EmitAssignment(stmt->each(), stmt->EachFeedbackSlot()); 1271 EmitAssignment(stmt->each(), stmt->EachFeedbackSlot());
1271 PrepareForBailoutForId(stmt->AssignmentId(), NO_REGISTERS); 1272 PrepareForBailoutForId(stmt->AssignmentId(), NO_REGISTERS);
1272 } 1273 }
(...skipping 4251 matching lines...) Expand 10 before | Expand all | Expand 10 after
5524 Assembler::target_address_at(pc_immediate_load_address)) == 5525 Assembler::target_address_at(pc_immediate_load_address)) ==
5525 reinterpret_cast<uint64_t>( 5526 reinterpret_cast<uint64_t>(
5526 isolate->builtins()->OsrAfterStackCheck()->entry())); 5527 isolate->builtins()->OsrAfterStackCheck()->entry()));
5527 return OSR_AFTER_STACK_CHECK; 5528 return OSR_AFTER_STACK_CHECK;
5528 } 5529 }
5529 5530
5530 5531
5531 } } // namespace v8::internal 5532 } } // namespace v8::internal
5532 5533
5533 #endif // V8_TARGET_ARCH_MIPS64 5534 #endif // V8_TARGET_ARCH_MIPS64
OLDNEW
« no previous file with comments | « src/mips/full-codegen-mips.cc ('k') | src/runtime.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698