src/x64/full-codegen-x64.cc - Issue 1160983004: [turbofan] First step towards sanitizing for-in and making it optimizable.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/x64/full-codegen-x64.cc

Issue 1160983004: [turbofan] First step towards sanitizing for-in and making it optimizable. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Add some comments. Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/x64/full-codegen-x64.cc

diff --git a/src/x64/full-codegen-x64.cc b/src/x64/full-codegen-x64.cc

index 22bc23c97bb5cf6ec093c6fb66588f2ebd7e8ae7..947de32072f0e0a1a9bb6d620746184fc91b16c6 100644

--- a/src/x64/full-codegen-x64.cc

+++ b/src/x64/full-codegen-x64.cc

@@ -1231,9 +1231,9 @@ void FullCodeGenerator::VisitForInStatement(ForInStatement* stmt) {

// just skip it.

__ Push(rcx); // Enumerable.

__ Push(rbx); // Current entry.

- __ InvokeBuiltin(Builtins::FILTER_KEY, CALL_FUNCTION);

+ __ CallRuntime(Runtime::kForInFilter, 2);

PrepareForBailoutForId(stmt->FilterId(), TOS_REG);

- __ Cmp(rax, Smi::FromInt(0));

+ __ CompareRoot(rax, Heap::kUndefinedValueRootIndex);

__ j(equal, loop_statement.continue_label());

__ movp(rbx, rax);

« no previous file with comments | « src/runtime/runtime-utils.h ('k') | tools/gyp/v8.gyp » ('j') | no next file with comments »